ci: bump node version to node16 (#17564)

* ci: bump node version to node16

* chore: remove `node-sass` - no longer used

Co-authored-by: Sagar Vora <sagar@resilient.tech>

.github/helper/install.sh

@@ -56,11 +56,6 @@ bench -v setup requirements --dev
 
 if [ "$TYPE" == "ui" ]; then sed -i 's/^web: bench serve/web: bench serve --with-coverage/g' Procfile; fi
 
-# install node-sass which is required for website theme test
-cd ./apps/frappe || exit
-yarn add node-sass@4.13.1
-cd ../..
-
 bench start &
 bench --site test_site reinstall --yes
 if [ "$TYPE" == "server" ]; then bench --site test_site_producer reinstall --yes; fi

.github/workflows/patch-mariadb-tests.yml

@@ -49,7 +49,7 @@ jobs:
         if: ${{ steps.check-build.outputs.build == 'strawberry' }}
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 16
           check-latest: true
 
       - name: Add to Hosts

.github/workflows/publish-assets-develop.yml

@@ -15,7 +15,7 @@ jobs:
           path: 'frappe'
       - uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 16
       - uses: actions/setup-python@v4
         with:
           python-version: '3.10'

.github/workflows/publish-assets-releases.yml

@@ -16,9 +16,11 @@ jobs:
       - uses: actions/checkout@v3
         with:
           path: 'frappe'
+
       - uses: actions/setup-node@v3
         with:
-          python-version: '12.x'
+          node-version: 16
+
       - uses: actions/setup-python@v4
         with:
           python-version: '3.10'

.github/workflows/release.yml

@@ -16,10 +16,10 @@ jobs:
         with:
           fetch-depth: 0
           persist-credentials: false
-      - name: Setup Node.js v14
+      - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 16
       - name: Setup dependencies
         run: |
           npm install @semantic-release/git @semantic-release/exec --no-save
@@ -31,4 +31,4 @@ jobs:
           GIT_AUTHOR_EMAIL: "developers@frappe.io"
           GIT_COMMITTER_NAME: "Frappe PR Bot"
           GIT_COMMITTER_EMAIL: "developers@frappe.io"
-        run: npx semantic-release 
+        run: npx semantic-release

.github/workflows/semantic-commits.yml

@@ -21,7 +21,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 16
           check-latest: true
 
       - name: Check commit titles

.github/workflows/server-mariadb-tests.yml

@@ -56,7 +56,7 @@ jobs:
       - uses: actions/setup-node@v3
         if: ${{ steps.check-build.outputs.build == 'strawberry' }}
         with:
-          node-version: 14
+          node-version: 16
           check-latest: true
 
       - name: Add to Hosts

.github/workflows/server-postgres-tests.yml

@@ -59,7 +59,7 @@ jobs:
       - uses: actions/setup-node@v3
         if: ${{ steps.check-build.outputs.build == 'strawberry' }}
         with:
-          node-version: '14'
+          node-version: '16'
           check-latest: true
 
       - name: Add to Hosts

.github/workflows/ui-tests.yml

@@ -55,7 +55,7 @@ jobs:
       - uses: actions/setup-node@v3
         if: ${{ steps.check-build.outputs.build == 'strawberry' }}
         with:
-          node-version: 14
+          node-version: 16
           check-latest: true
 
       - name: Add to Hosts