From d61123180c3ea99a280f6786209c8dd6d43f76ac Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Wed, 5 Oct 2016 16:34:06 +0530 Subject: [PATCH] Add error traceback in comment if no message_log --- frappe/model/document.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/frappe/model/document.py b/frappe/model/document.py index c4049b8524..ea1489b6c8 100644 --- a/frappe/model/document.py +++ b/frappe/model/document.py @@ -999,8 +999,12 @@ def execute_action(doctype, name, action, **kwargs): getattr(doc, action)(**kwargs) except frappe.ValidationError: # add a comment (?) - doc.add_comment('Comment', - _('Action Failed') + '

' + json.loads(frappe.local.message_log[-1]).get('message')) + if frappe.local.message_log: + msg = json.loads(frappe.local.message_log[-1]).get('message') + else: + msg = '
' + frappe.get_traceback() + '
' + + doc.add_comment('Comment', _('Action Failed') + '

' + msg) doc.notify_update() except Exception: