From d68187ab9679d3cc0fc95129716625154c5712db Mon Sep 17 00:00:00 2001
From: Jannat Patel <pateljannat2308@gmail.com>
Date: Thu, 17 Mar 2022 16:42:45 +0530
Subject: [PATCH] fix: empty state height

---
 .../public/js/frappe/web_form/web_form_list.js | 18 ++++++++----------
 frappe/public/scss/website/index.scss          | 13 +++++++++++++
 2 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/frappe/public/js/frappe/web_form/web_form_list.js b/frappe/public/js/frappe/web_form/web_form_list.js
index b7e92052a4..1f3628ac38 100644
--- a/frappe/public/js/frappe/web_form/web_form_list.js
+++ b/frappe/public/js/frappe/web_form/web_form_list.js
@@ -141,23 +141,21 @@ export default class WebFormList {
 			empty_state.classList.add("no-result", "text-muted", "flex", "justify-center", "align-center");
 
 			frappe.has_permission(this.doctype, "", "create", () => {
-				new_button = `<p><button class="btn btn-primary btn-sm btn-new-doc hidden-xs">
+				console.log(this)
+				new_button = `<a class="btn btn-primary btn-sm btn-new-doc hidden-xs" href="${window.location.pathname}?new=1">
 					${__("Create a new {0}", [__(this.doctype)])}
-					</button> <button class="btn btn-primary btn-new-doc visible-xs">
-					${__("Create New", null, "Create a new document from list view")}
-					</button></p>`;
-			});
+					</a>`;
 
-			empty_state.innerHTML = `<div class="text-center">
+				empty_state.innerHTML = `<div class="text-center">
 				<div>
-					<img src="/assets/frappe/images/ui-states/list-empty-state.svg" alt="Generic Empty State" class="empty-list-icon">
+					<img src="/assets/frappe/images/ui-states/list-empty-state.svg" alt="Generic Empty State" class="null-state">
 				</div>
-				<p class="mt-2 small">${__("No {0} found", [__(this.doctype)])}</p>
+				<p class="small mb-2">${__("No {0} found", [__(this.doctype)])}</p>
 				${new_button}`;
 
-			this.wrapper.appendChild(empty_state);
+				this.wrapper.appendChild(empty_state);
+			});
 		}
-
 	}
 
 	make_table_head() {
diff --git a/frappe/public/scss/website/index.scss b/frappe/public/scss/website/index.scss
index 2cc0f64f76..e36e649eb7 100644
--- a/frappe/public/scss/website/index.scss
+++ b/frappe/public/scss/website/index.scss
@@ -311,3 +311,16 @@ h5.modal-title {
 .empty-list-icon {
 	height: 70px;
 }
+
+.null-state {
+	height: 60px;
+	width: auto;
+	margin-bottom: var(--margin-md);
+	img {
+		fill: var(--fg-color);
+	}
+}
+
+.no-result {
+	min-height: #{"calc(100vh - 284px)"};
+}