From db0925d446494d7405add9652e9129773e6341e8 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Tue, 15 Mar 2022 12:46:36 +0530 Subject: [PATCH] fix: dont return docinfo as `message` The return was added for testability but it also becomes part of response so response size doubles. :) --- frappe/desk/form/load.py | 1 - frappe/tests/test_form_load.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/frappe/desk/form/load.py b/frappe/desk/form/load.py index b5dfacb1d6..dba84e5175 100644 --- a/frappe/desk/form/load.py +++ b/frappe/desk/form/load.py @@ -124,7 +124,6 @@ def get_docinfo(doc=None, doctype=None, name=None): update_user_info(docinfo) frappe.response["docinfo"] = docinfo - return docinfo def add_comments(doc, docinfo): # divide comments into separate lists diff --git a/frappe/tests/test_form_load.py b/frappe/tests/test_form_load.py index b10d5eb796..92694cf022 100644 --- a/frappe/tests/test_form_load.py +++ b/frappe/tests/test_form_load.py @@ -168,8 +168,8 @@ class TestFormLoad(unittest.TestCase): "reference_name": note.name, }).insert() - - docinfo = get_docinfo(note) + get_docinfo(note) + docinfo = frappe.response["docinfo"] self.assertEqual(len(docinfo.comments), 1) self.assertIn("test", docinfo.comments[0].content)