Browse Source

fix: dont return docinfo as `message`

The return was added for testability but it also becomes part of
response so response size doubles. :)
version-14
Ankush Menat 3 years ago
parent
commit
db0925d446
2 changed files with 2 additions and 3 deletions
  1. +0
    -1
      frappe/desk/form/load.py
  2. +2
    -2
      frappe/tests/test_form_load.py

+ 0
- 1
frappe/desk/form/load.py View File

@@ -124,7 +124,6 @@ def get_docinfo(doc=None, doctype=None, name=None):
update_user_info(docinfo)

frappe.response["docinfo"] = docinfo
return docinfo

def add_comments(doc, docinfo):
# divide comments into separate lists


+ 2
- 2
frappe/tests/test_form_load.py View File

@@ -168,8 +168,8 @@ class TestFormLoad(unittest.TestCase):
"reference_name": note.name,
}).insert()

docinfo = get_docinfo(note)
get_docinfo(note)
docinfo = frappe.response["docinfo"]

self.assertEqual(len(docinfo.comments), 1)
self.assertIn("test", docinfo.comments[0].content)


Loading…
Cancel
Save