From 7fbeb0afeed24fb975eed1e532ede8ee9695d206 Mon Sep 17 00:00:00 2001 From: Saurabh Date: Wed, 24 Jan 2018 19:25:42 +0530 Subject: [PATCH] [fix] check for exact label match to avoid duplication --- frappe/public/js/frappe/ui/page.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/ui/page.js b/frappe/public/js/frappe/ui/page.js index 076b443e32..038d0eb27b 100644 --- a/frappe/public/js/frappe/ui/page.js +++ b/frappe/public/js/frappe/ui/page.js @@ -263,7 +263,7 @@ frappe.ui.Page = Class.extend({ var $li = $('
  • '+ label +'
  • '), $link = $li.find("a").on("click", click); - if (this.is_in_group_button_dropdown(parent, `${item_selector}:contains('${label}')`, label)) return; + if (this.is_in_group_button_dropdown(parent, item_selector, label)) return; if(standard===true) { $li.appendTo(parent); @@ -289,7 +289,10 @@ frappe.ui.Page = Class.extend({ if (!label || !parent) return false; - const result = $(parent).find(`${selector}:contains('${label}')`); + const result = $(parent).find(`${selector}:contains('${label}')`) + .filter(function() { + return $(this).text() === label; + }); return result.length > 0; },