From e2d644803e666b507c8562e131e3750977de7a7c Mon Sep 17 00:00:00 2001 From: rohitwaghchaure Date: Mon, 3 Jul 2017 18:29:01 +0530 Subject: [PATCH] [Fix] Activity page is not working (#3601) * [Fix] Activity page is not working * Update base_list.js --- frappe/public/js/frappe/ui/base_list.js | 54 +++++++++++++------------ 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/frappe/public/js/frappe/ui/base_list.js b/frappe/public/js/frappe/ui/base_list.js index 80ea720dca..137ebfea83 100644 --- a/frappe/public/js/frappe/ui/base_list.js +++ b/frappe/public/js/frappe/ui/base_list.js @@ -184,33 +184,35 @@ frappe.ui.BaseList = Class.extend({ return; } - this.page.add_field({ - fieldtype:'Link', - options:this.doctype, - label:'ID', - fieldname:'name', - onchange: () => { me.refresh(true); } - }); - - this.meta.fields.forEach(function(df) { - if(df.in_standard_filter && !frappe.model.no_value_type.includes(df.fieldtype)) { - let options = df.options; - if(df.fieldtype == "Select" && df.options) { - options = df.options.split("\n") - if(options.length > 0 && options[0] != ""){ - options.unshift(""); - df.options = options.join("\n"); + if(this.meta) { + this.page.add_field({ + fieldtype:'Link', + options:this.doctype, + label:'ID', + fieldname:'name', + onchange: () => { me.refresh(true); } + }); + + this.meta.fields.forEach(function(df) { + if(df.in_standard_filter && !frappe.model.no_value_type.includes(df.fieldtype)) { + let options = df.options; + if(df.fieldtype == "Select" && df.options) { + options = df.options.split("\n") + if(options.length > 0 && options[0] != ""){ + options.unshift(""); + df.options = options.join("\n"); + } } + me.page.add_field({ + fieldtype: df.fieldtype, + label: __(df.label), + options: df.options, + fieldname: df.fieldname, + onchange: () => {me.refresh(true);} + }); } - me.page.add_field({ - fieldtype: df.fieldtype, - label: __(df.label), - options: df.options, - fieldname: df.fieldname, - onchange: () => {me.refresh(true);} - }); - } - }); + }); + } this.page.page_form.on('change', ':input', function() { me.refresh(true); @@ -507,4 +509,4 @@ frappe.ui.BaseList = Class.extend({ } }); } -}); \ No newline at end of file +});