Bladeren bron

Merge pull request #16081 from ankush/pg_dups

fix: explicitly ignore duplicates and skip migration_hash
version-14
Mohammad Hasnain Mohsin Rajan 3 jaren geleden
committed by GitHub
bovenliggende
commit
e401b8c2cd
Geen bekende sleutel gevonden voor deze handtekening in de database GPG sleutel-ID: 4AEE18F83AFDEB23
5 gewijzigde bestanden met toevoegingen van 7 en 6 verwijderingen
  1. +1
    -1
      frappe/desk/page/setup_wizard/setup_wizard.py
  2. +1
    -1
      frappe/desk/utils.py
  3. +3
    -2
      frappe/modules/import_file.py
  4. +1
    -1
      frappe/test_runner.py
  5. +1
    -1
      frappe/utils/install.py

+ 1
- 1
frappe/desk/page/setup_wizard/setup_wizard.py Bestand weergeven

@@ -392,7 +392,7 @@ def make_records(records, debug=False):
doc.flags.ignore_mandatory = True

try:
doc.insert(ignore_permissions=True)
doc.insert(ignore_permissions=True, ignore_if_duplicate=True)
frappe.db.commit()

except frappe.DuplicateEntryError as e:


+ 1
- 1
frappe/desk/utils.py Bestand weergeven

@@ -20,4 +20,4 @@ def validate_route_conflict(doctype, name):
raise frappe.NameError

def slug(name):
return name.lower().replace(' ', '-')
return name.lower().replace(' ', '-')

+ 3
- 2
frappe/modules/import_file.py Bestand weergeven

@@ -115,10 +115,11 @@ def import_file_by_path(path: str,force: bool = False,data_import: bool = False,

if not force or db_modified_timestamp:
try:
stored_hash = frappe.db.get_value(doc["doctype"], doc["name"], "migration_hash")
stored_hash = None
if doc["doctype"] == "DocType":
stored_hash = frappe.db.get_value(doc["doctype"], doc["name"], "migration_hash")
except Exception:
frappe.flags.dt += [doc["doctype"]]
stored_hash = None

# if hash exists and is equal no need to update
if stored_hash and stored_hash == calculated_hash:


+ 1
- 1
frappe/test_runner.py Bestand weergeven

@@ -392,7 +392,7 @@ def make_test_objects(doctype, test_records=None, verbose=None, reset=False):

try:
d.run_method("before_test_insert")
d.insert()
d.insert(ignore_if_duplicate=True)

if docstatus == 1:
d.submit()


+ 1
- 1
frappe/utils/install.py Bestand weergeven

@@ -90,7 +90,7 @@ def install_basic_docs():

for d in install_docs:
try:
frappe.get_doc(d).insert()
frappe.get_doc(d).insert(ignore_if_duplicate=True)
except frappe.NameError:
pass



Laden…
Annuleren
Opslaan