From e617dfbf98e19aa700dcfa54ddc3af03b78ee2cf Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Fri, 10 Nov 2017 14:21:06 +0530 Subject: [PATCH] Don't show submit, cancel, amend buttons for non submittable doctypes (#4448) --- .../core/page/permission_manager/permission_manager.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/frappe/core/page/permission_manager/permission_manager.js b/frappe/core/page/permission_manager/permission_manager.js index b0dc64de97..c986af35cc 100644 --- a/frappe/core/page/permission_manager/permission_manager.js +++ b/frappe/core/page/permission_manager/permission_manager.js @@ -155,7 +155,9 @@ frappe.PermissionEngine = Class.extend({ role: me.get_role() }, callback: function(r) { - me.render(r.message); + frappe.model.with_doc('DocType', me.get_doctype(), () => { + me.render(r.message); + }); } }); }, @@ -209,7 +211,10 @@ frappe.PermissionEngine = Class.extend({ var perm_cell = me.add_cell(row, d, "permissions").css("padding-top", 0); var perm_container = $("
").appendTo(perm_cell); - $.each(me.rights, function(i, r) { + const { is_submittable } = frappe.model.get_doc('DocType', me.get_doctype()); + + me.rights.forEach(r => { + if (!is_submittable && ['submit', 'cancel', 'amend'].includes(r)) return; me.add_check(perm_container, d, r); });