From eaa332e901369bd3265e889e55533a2eec0e4714 Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Fri, 1 Apr 2022 16:43:25 +0530 Subject: [PATCH] fix(goal): Make sure history field contains a JSON dump --- frappe/utils/goal.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/utils/goal.py b/frappe/utils/goal.py index fde948bcea..0a9116f0e5 100644 --- a/frappe/utils/goal.py +++ b/frappe/utils/goal.py @@ -7,7 +7,7 @@ import frappe from frappe import _ from frappe.query_builder.functions import DateFormat, Function from frappe.query_builder.utils import DocType -from frappe.utils.data import add_to_date, flt, now_datetime +from frappe.utils.data import add_to_date, cstr, flt, now_datetime from frappe.utils.formatters import format_value from contextlib import suppress @@ -86,11 +86,11 @@ def get_monthly_goal_graph_data( history = doc.get(goal_history_field) month_to_value_dict = None - if history: + if history and "{" in cstr(history): with suppress(ValueError): month_to_value_dict = frappe.parse_json(history) - if month_to_value_dict is None: + if month_to_value_dict is None: # nosemgrep doc_filter = {} with suppress(ValueError): doc_filter = frappe.parse_json(filters or "{}")