From eb9551fca7aa3ee3447aa3676ffad306170ea220 Mon Sep 17 00:00:00 2001 From: Saurabh Date: Fri, 12 May 2017 15:41:26 +0530 Subject: [PATCH] [fix] check all custom perms before adding permissions from standard docperm (#3280) --- frappe/permissions.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frappe/permissions.py b/frappe/permissions.py index 2455f8428a..22342d9811 100644 --- a/frappe/permissions.py +++ b/frappe/permissions.py @@ -330,7 +330,8 @@ def get_all_perms(role): '''Returns valid permissions for a given role''' perms = frappe.get_all('DocPerm', fields='*', filters=dict(role=role)) custom_perms = frappe.get_all('Custom DocPerm', fields='*', filters=dict(role=role)) - doctypes_with_custom_perms = list(set(p.parent for p in custom_perms)) + doctypes_with_custom_perms = frappe.db.sql_list("""select distinct parent + from `tabCustom DocPerm`""") for p in perms: if p.parent not in doctypes_with_custom_perms: