From e1497e1aadf81e26c65793d592a3e2109027310a Mon Sep 17 00:00:00 2001 From: barredterra <14891507+barredterra@users.noreply.github.com> Date: Fri, 21 Jan 2022 17:03:54 +0100 Subject: [PATCH] fix: translate fieldname in report dialog and alert --- frappe/public/js/frappe/views/reports/report_view.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/frappe/public/js/frappe/views/reports/report_view.js b/frappe/public/js/frappe/views/reports/report_view.js index 6d8e281793..f5d9f3e110 100644 --- a/frappe/public/js/frappe/views/reports/report_view.js +++ b/frappe/public/js/frappe/views/reports/report_view.js @@ -340,7 +340,7 @@ frappe.views.ReportView = class ReportView extends frappe.views.ListView { options: columns_in_picker }, { - label: __('Insert Column Before {0}', [datatabe_col.docfield.label.bold()]), + label: __('Insert Column Before {0}', [__(datatabe_col.docfield.label).bold()]), fieldname: 'insert_before', fieldtype: 'Check' } @@ -789,7 +789,10 @@ frappe.views.ReportView = class ReportView extends frappe.views.ListView { } else { this.fields.splice(col_index, 0, field); } - frappe.show_alert(__('Also adding the dependent currency field {0}', [field[0].bold()])); + const field_label = frappe.meta.get_label(doctype, field[0]); + frappe.show_alert( + __('Also adding the dependent currency field {0}', [__(field_label).bold()]) + ); } } @@ -799,7 +802,10 @@ frappe.views.ReportView = class ReportView extends frappe.views.ListView { const field = [col, doctype]; this.fields.push(field); this.refresh(); - frappe.show_alert(__('Also adding the status dependency field {0}', [field[0].bold()])); + const field_label = frappe.meta.get_label(doctype, field[0]); + frappe.show_alert( + __('Also adding the status dependency field {0}', [__(field_label).bold()]) + ); } }