From ed7b3f54a7453d2be9b8f25b8738649f377afcf5 Mon Sep 17 00:00:00 2001 From: Aradhya Date: Sat, 20 Nov 2021 13:21:01 +0530 Subject: [PATCH] refactor: converted more queries --- frappe/translate.py | 11 ++++++++--- frappe/twofactor.py | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/frappe/translate.py b/frappe/translate.py index 2905af6490..23072d064c 100644 --- a/frappe/translate.py +++ b/frappe/translate.py @@ -480,9 +480,14 @@ def get_messages_from_workflow(doctype=None, app_name=None): messages.extend([("Workflow: " + w['name'], state['message']) for state in states if is_translatable(state['message'])]) - actions = frappe.db.sql( - 'select distinct action from `tabWorkflow Transition` where parent=%s', - (w['name'],), as_dict=True) + actions = frappe.db.get_values( + "Workflow Transition", + filters={"parent": w["name"]}, + fieldname="action", + as_dict=True, + distinct=True, + no_order=True, + ) messages.extend([("Workflow: " + w['name'], action['action']) \ for action in actions if is_translatable(action['action'])]) diff --git a/frappe/twofactor.py b/frappe/twofactor.py index 6ae53ed717..bd49d588b0 100644 --- a/frappe/twofactor.py +++ b/frappe/twofactor.py @@ -417,4 +417,4 @@ def reset_otp_secret(user): enqueue(method=frappe.sendmail, queue='short', timeout=300, event=None, is_async=True, job_name=None, now=False, **email_args) return frappe.msgprint(_("OTP Secret has been reset. Re-registration will be required on next login.")) else: - return frappe.throw(_("OTP secret can only be reset by the Administrator.")) + return frappe.throw(_("OTP secret can only be reset by the Administrator.")) \ No newline at end of file