From 861ff16ac8d045f5a35191c2f15a182d9e46a183 Mon Sep 17 00:00:00 2001
From: barredterra <14891507+barredterra@users.noreply.github.com>
Date: Sat, 5 Mar 2022 19:53:45 +0100
Subject: [PATCH 1/4] refactor: `frappe.db.exists`

---
 frappe/database/database.py | 50 +++++++++++++++++++++++--------------
 1 file changed, 31 insertions(+), 19 deletions(-)

diff --git a/frappe/database/database.py b/frappe/database/database.py
index dc9f20d8c2..9b1828f811 100644
--- a/frappe/database/database.py
+++ b/frappe/database/database.py
@@ -884,27 +884,39 @@ class Database(object):
 		return self.sql("select name from `tab{doctype}` limit 1".format(doctype=doctype))
 
 	def exists(self, dt, dn=None, cache=False):
-		"""Returns true if document exists.
+		"""Return the document name of a matching document, or None.
 
-		:param dt: DocType name.
-		:param dn: Document name or filter dict."""
-		if isinstance(dt, str):
-			if dt!="DocType" and dt==dn:
-				return True # single always exists (!)
-			try:
-				return self.get_value(dt, dn, "name", cache=cache)
-			except Exception:
-				return None
+		Note: `cache` only works if `dt` and `dn` are of type `str`.
 
-		elif isinstance(dt, dict) and dt.get('doctype'):
-			try:
-				conditions = []
-				for d in dt:
-					if d == 'doctype': continue
-					conditions.append([d, '=', dt[d]])
-				return self.get_all(dt['doctype'], filters=conditions, as_list=1)
-			except Exception:
-				return None
+		## Examples
+
+		Pass doctype and docname (only in this case we can cache the result)
+
+		```
+		exists("User", "jane@example.org", cache=True)
+		```
+
+		Pass a dict of filters including the `"doctype"` key:
+
+		```
+		exists({"doctype": "User", "full_name": "Jane Doe"})
+		```
+
+		Pass the doctype and a dict of filters:
+
+		```
+		exists("User", {"full_name": "Jane Doe"})
+		```
+		"""
+		if dt == dn:
+			# single always exists (!)
+			return dn
+
+		if isinstance(dt, dict):
+			_dt = dt.pop("doctype")
+			dt, dn = _dt, dt
+
+		return self.get_value(dt, dn, ignore=True, cache=cache)
 
 	def count(self, dt, filters=None, debug=False, cache=False):
 		"""Returns `COUNT(*)` for given DocType and filters."""

From 734d0b4fe8f6ee0e810d7e5bb205329ad9acf80a Mon Sep 17 00:00:00 2001
From: barredterra <14891507+barredterra@users.noreply.github.com>
Date: Thu, 17 Mar 2022 01:35:46 +0100
Subject: [PATCH 2/4] test: frappe.db.exists

---
 frappe/tests/test_db.py | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/frappe/tests/test_db.py b/frappe/tests/test_db.py
index bbd09590be..504a1eb3b8 100644
--- a/frappe/tests/test_db.py
+++ b/frappe/tests/test_db.py
@@ -301,6 +301,14 @@ class TestDB(unittest.TestCase):
 			# recover transaction to continue other tests
 			raise Exception
 
+	def test_exists(self):
+		dt, dn = "User", "Administrator"
+		self.assertEqual(frappe.db.exists(dt, dn, cache=True), dn)
+		self.assertEqual(frappe.db.exists(dt, dn), dn)
+		self.assertEqual(frappe.db.exists(dt, {"name": ("=", dn)}), dn)
+		self.assertEqual(frappe.db.exists({"doctype": dt, "name": ("like", "Admin%")}), dn)
+		self.assertEqual(frappe.db.exists(dt, [["name", "=", dn]]), dn)
+
 
 @run_only_if(db_type_is.MARIADB)
 class TestDDLCommandsMaria(unittest.TestCase):

From 7e550e919ca51d5986314db9a6227cb988f5644f Mon Sep 17 00:00:00 2001
From: barredterra <14891507+barredterra@users.noreply.github.com>
Date: Thu, 17 Mar 2022 02:07:23 +0100
Subject: [PATCH 3/4] revert: don't check for doctype (861ff16)

---
 frappe/database/database.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frappe/database/database.py b/frappe/database/database.py
index 9b1828f811..5d91e0b4f1 100644
--- a/frappe/database/database.py
+++ b/frappe/database/database.py
@@ -908,7 +908,7 @@ class Database(object):
 		exists("User", {"full_name": "Jane Doe"})
 		```
 		"""
-		if dt == dn:
+		if dt != "DocType" and dt == dn:
 			# single always exists (!)
 			return dn
 

From c26cf2547885b7b9c6d608a23c273d1501dd2f07 Mon Sep 17 00:00:00 2001
From: barredterra <14891507+barredterra@users.noreply.github.com>
Date: Thu, 17 Mar 2022 02:46:00 +0100
Subject: [PATCH 4/4] fix: avoid invalid call to frappe.db.exists

---
 frappe/model/base_document.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frappe/model/base_document.py b/frappe/model/base_document.py
index 8a81aa5610..c251325bcb 100644
--- a/frappe/model/base_document.py
+++ b/frappe/model/base_document.py
@@ -963,7 +963,7 @@ class BaseDocument(object):
 			from frappe.model.meta import get_default_df
 			df = get_default_df(fieldname)
 
-		if not currency and df:
+		if df.fieldtype == "Currency" and not currency:
 			currency = self.get(df.get("options"))
 			if not frappe.db.exists('Currency', currency, cache=True):
 				currency = None