Shariq Ansari
c219f2a5dc
Merge pull request #18388 from frappe/mergify/bp/version-14-hotfix/pr-18380
2 years ago
Shariq Ansari
5eb803ca95
fix: format currency value as float while grid upload
(cherry picked from commit 95f23b3adb
)
2 years ago
mergify[bot]
23caa1f93b
perf: Perform `db.set_value` with single query only (backport #18305 ) ( #18349 )
* perf: single query `db.set_value`
(cherry picked from commit cee2b50461
)
* fix: better cache validation
- Only delete a single doc if we know which doc changed
- Drop all docs other wise (kinda bad, but this isn't used frequently,
will fix when visiting entire caching system again)
(cherry picked from commit bfa6a5fbdf
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 years ago
Ankush Menat
702e8674f9
refactor: use file api to read import data ( #18379 )
* refactor: use file api for reading data in import
* fix: remove unused import
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Faris Ansari <netchampfaris@users.noreply.github.com>
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2 years ago
Frappe PR Bot
042b2dbf42
chore(release): Bumped to Version 14.11.1
## [14.11.1](https://github.com/frappe/frappe/compare/v14.11.0...v14.11.1 ) (2022-10-11)
### Bug Fixes
* trigger release ([5e2ac2c
](5e2ac2c745
))
2 years ago
Ankush Menat
4863d4c650
Merge pull request #18378 from frappe/version-14-hotfix
chore: v14 release
2 years ago
mergify[bot]
f52a8c52dc
build(deps): bump oauthlib ( #18377 )
CVE-2022-36087 - https://github.com/advisories/GHSA-3pgj-pg6c-r5p7
(cherry picked from commit 29d423ef18
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 years ago
Ankush Menat
5e2ac2c745
fix: trigger release
semantic bot needs fix/feat
2 years ago
Frappe PR Bot
341bd0221c
chore(release): Bumped to Version 14.11.0
# [14.11.0](https://github.com/frappe/frappe/compare/v14.10.0...v14.11.0 ) (2022-10-11)
### Bug Fixes
* always show list filters and add confirmation when deleting filters (backport [#18343 ](https://github.com/frappe/frappe/issues/18343 )) ([#18348 ](https://github.com/frappe/frappe/issues/18348 )) ([372dc2a
](372dc2a51d
))
* convert string check to tuple check ([8be9e1b
](8be9e1b180
))
* correct index re-syncing ([10e1eed
](10e1eed077
))
* disable autocommit before each patch ([#18307 ](https://github.com/frappe/frappe/issues/18307 )) ([#18308 ](https://github.com/frappe/frappe/issues/18308 )) ([c13bd94
](c13bd94049
))
* ignore if df doesn't exist ([#18358 ](https://github.com/frappe/frappe/issues/18358 )) ([#18360 ](https://github.com/frappe/frappe/issues/18360 )) ([e9ecef7
](e9ecef7c11
))
* ignore perm level validation if row deleted ([#18290 ](https://github.com/frappe/frappe/issues/18290 )) ([#18292 ](https://github.com/frappe/frappe/issues/18292 )) ([0d5dffe
](0d5dffeefa
))
* index column should be first ([dd7faf5
](dd7faf5bdc
))
* let charts handle aggregation ([#18293 ](https://github.com/frappe/frappe/issues/18293 )) ([#18295 ](https://github.com/frappe/frappe/issues/18295 )) ([e0974c5
](e0974c53ab
))
* link field self linking ([#18330 ](https://github.com/frappe/frappe/issues/18330 )) ([#18357 ](https://github.com/frappe/frappe/issues/18357 )) ([bbfab52
](bbfab52f5b
))
* make --record optional for cypress tests ([#18332 ](https://github.com/frappe/frappe/issues/18332 )) ([db3736e
](db3736eff3
))
* make --record optional for cypress tests [#18341 ](https://github.com/frappe/frappe/issues/18341 ) ([6659282
](66592827f4
))
* **notification:** redirect to the referenced document if present otherwise go to notification log ([#18334 ](https://github.com/frappe/frappe/issues/18334 )) ([#18339 ](https://github.com/frappe/frappe/issues/18339 )) ([9cafce8
](9cafce85bb
))
* responsive ([83d49d1
](83d49d184c
))
* Set email account in Communication only if exists ([#18361 ](https://github.com/frappe/frappe/issues/18361 )) ([3282805
](3282805294
))
* set system time on doc for `Now` ([#18288 ](https://github.com/frappe/frappe/issues/18288 )) ([#18328 ](https://github.com/frappe/frappe/issues/18328 )) ([e7ff04c
](e7ff04c4e7
))
* type-error in email signature code ([#18353 ](https://github.com/frappe/frappe/issues/18353 )) ([#18363 ](https://github.com/frappe/frappe/issues/18363 )) ([271e4d6
](271e4d69ce
))
### Features
* allow auto clearing notificaiton log ([#18344 ](https://github.com/frappe/frappe/issues/18344 )) ([#18345 ](https://github.com/frappe/frappe/issues/18345 )) ([316abf2
](316abf2095
))
2 years ago
Ankush Menat
84389851ea
Merge pull request #18369 from frappe/version-14-hotfix
chore: release v14
2 years ago
Shariq Ansari
96e8912d0d
Merge pull request #18368 from frappe/mergify/bp/version-14-hotfix/pr-18315
2 years ago
Shariq Ansari
83d49d184c
fix: responsive
(cherry picked from commit 16fb96f6bd
)
2 years ago
Shadrak Gurupnor
efb29e20db
chore: reduce margin to occupy more items
(cherry picked from commit 6a492840ce
)
2 years ago
Ritwik Puri
59f00b4540
Merge pull request #18364 from frappe/mergify/bp/version-14-hotfix/pr-18361
fix: Set email account in Communication only if exists (backport #18361 )
2 years ago
Nabin Hait
3282805294
fix: Set email account in Communication only if exists ( #18361 )
(cherry picked from commit e821699c82
)
2 years ago
mergify[bot]
271e4d69ce
fix: type-error in email signature code ( #18353 ) ( #18363 )
* fix: type-error in email signature code
* refactor: import
[skip ci]
Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 768daf0961
)
Co-authored-by: stephen <stephenBDT@users.noreply.github.com>
2 years ago
mergify[bot]
e9ecef7c11
fix: ignore if df doesn't exist ( #18358 ) ( #18360 )
(cherry picked from commit b03e0752b9
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 years ago
mergify[bot]
bbfab52f5b
fix: link field self linking ( #18330 ) ( #18357 )
(cherry picked from commit 426ecc5a1e
)
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2 years ago
mergify[bot]
372dc2a51d
fix: always show list filters and add confirmation when deleting filters (backport #18343 ) ( #18348 )
* feat: auto-show list filters and add confirmation when deleting filters
(cherry picked from commit 683db938e3
)
* fix(UX): always show saved filters
(cherry picked from commit f063194e20
)
Co-authored-by: Rohan Bansal <rohan@parsimony.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 years ago
mergify[bot]
4c5d468747
chore: fix es translations ( #18347 )
Typo corrections and translations added.
(cherry picked from commit df9417fa25
)
Co-authored-by: avc <94137451+git-avc@users.noreply.github.com>
2 years ago
mergify[bot]
3524dfd1d4
ci: Verify yarn lock file ( #18336 ) ( #18338 )
(cherry picked from commit 66710ae5c5
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 years ago
mergify[bot]
316abf2095
feat: allow auto clearing notificaiton log ( #18344 ) ( #18345 )
(cherry picked from commit 4020513712
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 years ago
mergify[bot]
9cafce85bb
fix(notification): redirect to the referenced document if present otherwise go to notification log ( #18334 ) ( #18339 )
(cherry picked from commit 121a6e1108
)
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2 years ago
Ankush Menat
66592827f4
fix: make --record optional for cypress tests #18341
2 years ago
Ankush Menat
e510104a7d
chore: record UI runs
2 years ago
mergify[bot]
132b089f32
build(deps): bump snyk from 1.707.0 to 1.996.0 ( #18311 ) ( #18337 )
Bumps [snyk](https://github.com/snyk/snyk ) from 1.707.0 to 1.996.0.
- [Release notes](https://github.com/snyk/snyk/releases )
- [Commits](https://github.com/snyk/snyk/compare/v1.707.0...v1.996.0 )
---
updated-dependencies:
- dependency-name: snyk
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 6c2f73a030
)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 years ago
Revant Nandgaonkar
db3736eff3
fix: make --record optional for cypress tests ( #18332 )
2 years ago
mergify[bot]
e7ff04c4e7
fix: set system time on doc for `Now` ( #18288 ) ( #18328 )
(cherry picked from commit 4a3259ed92
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 years ago
Ankush Menat
160a15bac1
Merge pull request #18320 from frappe/mergify/bp/version-14-hotfix/pr-18318
fix: convert string check to tuple check (backport #18318 )
2 years ago
Faris Ansari
8be9e1b180
fix: convert string check to tuple check
breaks as `'in <string>' requires string as left operand` when
df.fieldtype is None
(cherry picked from commit c00d9f5267
)
2 years ago
Shariq Ansari
3a4dd0ae5e
Merge pull request #18309 from frappe/mergify/bp/version-14-hotfix/pr-18306
2 years ago
Shariq Ansari
1c7da81273
test: minor change
(cherry picked from commit 458757708f
)
2 years ago
Shariq Ansari
d1944a5e28
test: minor change
(cherry picked from commit 930f8c34ed
)
2 years ago
Shariq Ansari
9de6614e41
test: flaky Cypress test
(cherry picked from commit 36bc9d3142
)
2 years ago
mergify[bot]
c13bd94049
fix: disable autocommit before each patch ( #18307 ) ( #18308 )
(cherry picked from commit 1d186db6a6
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 years ago
Ankush Menat
0bb1f29af5
Merge pull request #18297 from frappe/mergify/bp/version-14-hotfix/pr-18262
fix: correct index syncing (backport #18262 )
2 years ago
Ankush Menat
dd7faf5bdc
fix: index column should be first
(cherry picked from commit da561c237d
)
2 years ago
Ankush Menat
10e1eed077
fix: correct index re-syncing
The implementation of syncing unique and non-unique index depended on
index names which used to be different before because of that there's
tendency to incorrectly identify index.
This PR adds a separate util for checking if a column has index without
relying on naming convention. It just goes and checks if there's any
index with that column in it, hence far more reliable.
(cherry picked from commit cbe4b59100
)
2 years ago
Ankush Menat
073daae6c1
refactor: guard clause
(cherry picked from commit 6de41a78e9
)
2 years ago
mergify[bot]
e0974c53ab
fix: let charts handle aggregation ( #18293 ) ( #18295 )
Currently we are doing aggregation of remaining slices manually BUT this
breaks basic principle of DRY:
- dashboard chart decides how many groups to consider
- frappe charts has different maxSlices config
This results in mess like frappe computing "Other" and Frappe charts
computing "rest" separately.
Fix: Just pass all data to charts and let it figure out the "Rest".
(cherry picked from commit d597acb5e2
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 years ago
mergify[bot]
0d5dffeefa
fix: ignore perm level validation if row deleted ( #18290 ) ( #18292 )
(cherry picked from commit bd21398252
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 years ago
Frappe PR Bot
ea296321b9
chore(release): Bumped to Version 14.10.0
# [14.10.0](https://github.com/frappe/frappe/compare/v14.9.0...v14.10.0 ) (2022-10-04)
### Bug Fixes
* add translate function to some strings (backport [#18188 ](https://github.com/frappe/frappe/issues/18188 )) ([#18242 ](https://github.com/frappe/frappe/issues/18242 )) ([c929fe6
](c929fe6c2a
))
* Chart date format on x-axis is inaccurate ([#18191 ](https://github.com/frappe/frappe/issues/18191 )) ([#18207 ](https://github.com/frappe/frappe/issues/18207 )) ([f940c7b
](f940c7b1a9
))
* Chart filter not working if not operator is used (backport [#18194 ](https://github.com/frappe/frappe/issues/18194 )) ([#18265 ](https://github.com/frappe/frappe/issues/18265 )) ([775ed71
](775ed71fd1
))
* **Data Import:** don't validate empty values ([#17923 ](https://github.com/frappe/frappe/issues/17923 )) ([#18275 ](https://github.com/frappe/frappe/issues/18275 )) ([26bfbf0
](26bfbf0cfc
))
* dont assume issingle exists ([#18236 ](https://github.com/frappe/frappe/issues/18236 )) ([#18252 ](https://github.com/frappe/frappe/issues/18252 )) ([6164921
](6164921304
))
* geolocation ([#18250 ](https://github.com/frappe/frappe/issues/18250 )) ([#18282 ](https://github.com/frappe/frappe/issues/18282 )) ([3e70643
](3e70643a39
))
* handle isatty correctly ([#18277 ](https://github.com/frappe/frappe/issues/18277 )) ([#18278 ](https://github.com/frappe/frappe/issues/18278 )) ([7ce396e
](7ce396ea59
))
* ignore child tables when init-ing parent doc ([84a58b3
](84a58b3a34
))
* **minor:** More button in list view ([#18283 ](https://github.com/frappe/frappe/issues/18283 )) ([#18284 ](https://github.com/frappe/frappe/issues/18284 )) ([99b8bbd
](99b8bbd0ff
))
* only allow verified_command on GET requests ([#18235 ](https://github.com/frappe/frappe/issues/18235 )) ([#18238 ](https://github.com/frappe/frappe/issues/18238 )) ([d974143
](d974143707
))
* report generation - frappe monitor ([#18259 ](https://github.com/frappe/frappe/issues/18259 )) ([#18260 ](https://github.com/frappe/frappe/issues/18260 )) ([d860e20
](d860e2087c
))
* throw exception if backup failed ([#18230 ](https://github.com/frappe/frappe/issues/18230 )) ([#18255 ](https://github.com/frappe/frappe/issues/18255 )) ([0f71fd2
](0f71fd2194
))
### Features
* Added Subscription Banner for remotely logging into FrappeCloud dashboard from site ([#18263 ](https://github.com/frappe/frappe/issues/18263 )) ([68f315d
](68f315d372
))
### Performance Improvements
* use `modified` instead of `creation` in scheduler ([#18234 ](https://github.com/frappe/frappe/issues/18234 )) ([#18240 ](https://github.com/frappe/frappe/issues/18240 )) ([6245b91
](6245b915ea
))
2 years ago
Ankush Menat
192e34d200
Merge pull request #18286 from frappe/version-14-hotfix
chore: release v14
2 years ago
Ankush Menat
84a58b3a34
fix: ignore child tables when init-ing parent doc
(cherry picked from commit b8ed8d624c
)
2 years ago
mergify[bot]
99b8bbd0ff
fix(minor): More button in list view ( #18283 ) ( #18284 )
(cherry picked from commit c1c4ee8b04
)
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2 years ago
mergify[bot]
3e70643a39
fix: geolocation ( #18250 ) ( #18282 )
- set center and zoom for leaflet.
Co-authored-by: Abhinav Raut <abhinav.raut@zerodha.com>
(cherry picked from commit fd81a290b2
)
Co-authored-by: Abhinav Raut <abhinavrautcs@gmail.com>
2 years ago
Ankush Menat
3f713de256
chore: codeowners
2 years ago
Rutwik Hiwalkar
68f315d372
feat: Added Subscription Banner for remotely logging into FrappeCloud dashboard from site ( #18263 )
* feat: added Subscription Banner and Manage Subscription button
* feat[patch]: added a patch for adding `Manage Subscription` button in
navbar_settings
* chore: removed console ;)
* refactor: make the `Manage Subscription` navbar item optional
* keep it hidden by default, only show when the site configs are present
* style: prettier, isort and stuff
* chore: handling null responses, translation and refactored patch
* fix: correct index reset
* perf: reduce network/db calls
If not sys manager then why make a request?
* fix: removed network call and added subscription_expiry to boot process
* chore: added enable_manage_susbcriptions as daily background job and refactored patch
* chore: added hook to hooks.py
* this looks clean enough, also don't have insert for child tables ;)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 years ago
mergify[bot]
26bfbf0cfc
fix(Data Import): don't validate empty values ( #17923 ) ( #18275 )
* refactor: exclude header from column values earlier
* fix: don't validate empty columns
Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 513321810d
)
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2 years ago
mergify[bot]
7ce396ea59
fix: handle isatty correctly ( #18277 ) ( #18278 )
sys.stdin can be `None`
[skip ci]
(cherry picked from commit 35ba00a54e
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 years ago