mergify[bot]
|
10faee0a04
|
feat: custom __link_options (#17699) (#17838)
* feat: custom __link_optins
* chore: linter fixes
* test: add ui test for custom link option
(cherry picked from commit 1aa3f75d4c )
Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
|
2 years ago |
hrwx
|
d50db2e0c6
|
chore: remove untranslated matching
(cherry picked from commit 42a3fe0fa2 )
|
2 years ago |
hrwx
|
1b1886f054
|
chore: linter fixes
(cherry picked from commit db2e898397 )
|
2 years ago |
hrwx
|
2834ce1b63
|
refactor: translatable doctypes
(cherry picked from commit b01929405d )
# Conflicts:
# frappe/contacts/doctype/gender/gender.json
# frappe/contacts/doctype/salutation/salutation.json
|
2 years ago |
Ankush Menat
|
5d6b24f0b1
|
style: format JS files with prettier
(cherry picked from commit 40f27f908a )
|
3 years ago |
Himanshu
|
70409a3c7b
|
fix: set translated text to link field (#15451)
- Fixes [Issue/15324](https://github.com/frappe/frappe/issues/15324)
- When selecting a value for Link Field, the English text was set as link field value.
- This PR aims to fix it by setting the translated text as link field value on selection.
Todo:
- [x] Show translated text in the select dropdown
- [x] Set translated value to Link field on select
- [x] Show original value when link field is in focus
- [x] Add option to toggle this behaviour
### Behaviour
- Link field loses focus: show the translated name.
- Link field is focused
- If old value is present
- If options **are** one of [Role, DocType]: show the translated name
- Else: show the name (untranslated) to enable search in untranslated values
- Else: show what the user typed (untranslated) to enable search in untranslated values
- Value is selected: link field loses focus
## Demo
### Link to UOM in a custom Item DocType
The UOM names are in english, so the search needs to happen in english. When possible, the translation is displayed.
#### Before
https://user-images.githubusercontent.com/14891507/156415248-e5e80d05-53dc-4ca8-89c7-998986ff6e99.mov
#### After
https://user-images.githubusercontent.com/14891507/156410386-a874430c-f340-43ed-9c3a-92e8d4d50fc9.mov
### Link to DocType in Customize Form
The DocType names get translated before being searched. This is a preexisting hack in the framework for DocType and Role. In this case, we can search in the translations.
#### Before
https://user-images.githubusercontent.com/14891507/156414648-8e505f8c-9dee-4358-8182-3b358c28bb62.mov
#### After
https://user-images.githubusercontent.com/14891507/156411881-c4ca22e1-1397-4e13-9768-5e16b72f8d6d.mov
https://docs.erpnext.com/docs/v13/user/manual/en/customize-erpnext/customize-form/edit?wiki_page_patch=fdafee2715
|
3 years ago |
Saqib Ansari
|
8a882cf09a
|
chore: add missing semicolon
|
3 years ago |
Saqib Ansari
|
cd3a6261fb
|
chore: remove property setter after test
|
3 years ago |
Saqib Ansari
|
bbbeb342df
|
fix: test for show title field in link fields
|
3 years ago |
Suraj Shetty
|
ebd756c1e5
|
test: Update test case for default value in link field
|
3 years ago |
Suraj Shetty
|
5f64dac3c1
|
test: Update UI test for link field
|
3 years ago |
Saqib Ansari
|
74276ef69b
|
chore: undo changes to link ui test
|
3 years ago |
Sagar Vora
|
0b0f896258
|
fix: cleaner implementation for link validation
|
3 years ago |
Sagar Vora
|
1fd53c4306
|
test: intercept `validate_link` instead of `get_value`
|
3 years ago |
Sagar Vora
|
7aa8059b57
|
test: add UI test to ensure `fetch_from` works
|
3 years ago |
Sagar Vora
|
f2b319920c
|
refactor: improved design for fetching values using `add_fetch`
|
3 years ago |
MitulDavid
|
93198b7123
|
test: Replace existing queries with Testing-Library queries
|
3 years ago |
MitulDavid
|
b417218f1d
|
test: Add support for Testing-Library queries within Cypress tests
|
3 years ago |
hrwx
|
d056beb0ef
|
feat: show title links in Link Fields
|
4 years ago |
Suraj Shetty
|
1f96f3d83c
|
style: Fix indentation
|
4 years ago |
Suraj Shetty
|
d18751db07
|
test: Make tests Cypress v6 compatible
|
4 years ago |
Rushabh Mehta
|
b2686e0623
|
fix(routing): removed /space from routing
|
4 years ago |
prssanna
|
841c1b9852
|
fix: cypress tests
|
4 years ago |
Rushabh Mehta
|
54cee87826
|
fix(minor): tests + routing
|
4 years ago |
Shivam Mishra
|
b97c0e24a1
|
test: rename workspace to space
|
4 years ago |
Rushabh Mehta
|
06355968f8
|
fix(routes): move /app#route to /app/route
|
4 years ago |
Rushabh Mehta
|
75fe8a615a
|
feat(app): move /desk to /app
|
4 years ago |
Shivam Mishra
|
e33bcfa6bd
|
style: fix linting issue
|
5 years ago |
Shivam Mishra
|
5d5cb26143
|
fix: add delay in typing
|
5 years ago |
Shivam Mishra
|
7a1cb7fa00
|
refactor: don't login before each test
|
5 years ago |
Shivam Mishra
|
372b64709b
|
refactor: set base desk url for cypress tests
|
5 years ago |
Faris Ansari
|
9dad73c300
|
test: More robust control link test
|
5 years ago |
Faris Ansari
|
ffa8038e4c
|
test: Fix Control Link test
|
5 years ago |
Faris Ansari
|
ea7d75c523
|
test: Remove .only
|
5 years ago |
Faris Ansari
|
d719f77edb
|
fix(ui-tests): Pick admin password from config (#7842)
|
6 years ago |
Faris Ansari
|
8fb2a538ec
|
test: Add UI test for Link control (#7809)
* test: Add UI test for Link control
- Add API cy.call
- Add API cy.create_records
- Add ui_test_helpers.py
* style: Missing semicolon
* style: Missing semicolon
* style: Missing semicolon
* style: Remove unused imports
* test: Robust test for setting invalid value
* style: Remove unused import
|
6 years ago |