Karthikeyan Singaravelan
880832671a
fix: use assertEqual instead of assertEquals for Python 3.11 compatibility
3 years ago
Suraj Shetty
47d9f0573d
Merge pull request #16353 from frappe/mergify/bp/develop/pr-16018
3 years ago
Sagar Vora
810867a0d5
fix: merge conflict
3 years ago
Isaiah Galorport
dbb622fce1
fix: Other user must not able to delete other user's comment except System Manager ( #16018 )
* fix: Other user must not able to delete other user's comment except Admin
* Update frappe/public/js/frappe/form/footer/form_timeline.js
Co-authored-by: Sagar Vora <sagar@resilient.tech>
* fix: Close condition scope
Co-authored-by: Sagar Vora <sagar@resilient.tech>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
(cherry picked from commit e4137ca8a1
)
# Conflicts:
# frappe/public/js/frappe/form/footer/form_timeline.js
3 years ago
mergify[bot]
3c37944f44
Merge pull request #16334 from ankush/exists_go_brrr
perf: limit rows to 1 for `get_value` and `exists`
3 years ago
Komal-Saraf0609
7fbbf577c9
test: fixing sider issues
3 years ago
Komal-Saraf0609
a139d1d369
test: fixing sider issues
3 years ago
Komal-Saraf0609
9b69f4e08c
test: fixing sider issues
3 years ago
Komal-Saraf0609
38c6db06ea
test: Added test script for control type "Dynamic Link"
3 years ago
Ankush Menat
1054a1203e
fix: assinging thread locals to global variables
3 years ago
Ankush Menat
a832aa27af
chore: whitespace
3 years ago
Shariq Ansari
fbac6fbfb4
fix: only remove \n\t from start and end
(cherry picked from commit 7bb172365f
)
# Conflicts:
# frappe/database/database.py
3 years ago
Shariq Ansari
b2c0bf7a4e
fix: remove tab \t and newlines \n from start of query and remove from middle
(cherry picked from commit ac5effc7dd
)
# Conflicts:
# frappe/database/database.py
3 years ago
Shariq Ansari
10fbb4330a
fix: setting permissions to any role of some doctypes is not working
(cherry picked from commit 6612232bab
)
# Conflicts:
# frappe/permissions.py
3 years ago
Ankush Menat
85428e817d
test: get_value(s) with limits
3 years ago
Ankush Menat
b97cfed6d7
perf: limit rows to 1 for get_value and exists
3 years ago
mergify[bot]
f47331cd1d
Merge pull request #16200 from alyf-de/refactor-db-exists
refactor: `frappe.db.exists`
3 years ago
mergify[bot]
9032cb25fe
Merge pull request #16220 from pateljannat/web-form-list-empty-state
fix: web form list empty state
3 years ago
mergify[bot]
49621746b7
Merge pull request #16213 from pateljannat/web-form-list-button
fix: web form list button
3 years ago
Suraj Shetty
afd5956e31
style: Fix formatting
3 years ago
Jannat Patel
4cbbc9a658
Merge branch 'develop' into discussions-component-redesign
3 years ago
Jannat Patel
039566a81b
Merge branch 'develop' into web-form-list-button
3 years ago
Jannat Patel
d5b62d4d2d
Merge branch 'develop' into web-form-list-empty-state
3 years ago
mergify[bot]
2c5a0b084e
Merge pull request #16338 from alyf-de/remove-useless-fallback
refactor: remove unused fallback value
3 years ago
barredterra
f650408daa
refactor: use frappe.parse_json
3 years ago
barredterra
2718685368
refactor: update_in_all_rows
3 years ago
mergify[bot]
cf0765916e
Merge pull request #16340 from alyf-de/refactor-backup-utils
fix: backup utils
3 years ago
mergify[bot]
5c709b3750
Merge pull request #16341 from alyf-de/remove-useless-pass
refactor: remove useless pass, log error
3 years ago
Himanshu
3bab770bec
Merge pull request #16342 from alyf-de/fix-concat
fix: use result of `Array.concat()`
3 years ago
barredterra
9a2a2e7abe
fix: assign result of concat
3 years ago
barredterra
8a4f316ec5
refactor: remove useless pass, log error
3 years ago
barredterra
1d3ec42974
fix: send_email doesn't take arguments
3 years ago
barredterra
4b8efc5ebd
fix: typo in parameter name
3 years ago
barredterra
0d8733c462
refactor: remove unused import
3 years ago
barredterra
a6c9b23471
refactor: use local method refresh_field
3 years ago
barredterra
687ca6972d
refactor: remove unused fallback
3 years ago
barredterra
1934340a1b
refactor: don't assign variable to itself
3 years ago
Himanshu
fd374150fd
Merge branch 'develop' into fix_parse_email_test
3 years ago
hrwx
5187663d73
chore: prefix test for parse_email
3 years ago
hrwx
e5b32c326b
chore: sider fixes
3 years ago
hrwx
0a94d025a2
feat: use mobile native camera
3 years ago
hrwx
d5969e2e64
Merge branch 'develop' of https://github.com/frappe/frappe into camera_upload
3 years ago
Jannat Patel
47fd92c272
Merge branch 'discussions-component-redesign' of https://github.com/pateljannat/frappe into discussions-component-redesign
3 years ago
Jannat Patel
f787d101e1
fix: conflicts in ui test helper
3 years ago
Jannat Patel
def2b6fbd1
Merge branch 'develop' into web-form-list-button
3 years ago
Suraj Shetty
abd421fa02
Merge pull request #12466 from shariquerik/user-permission-not-saved-fix
3 years ago
Suraj Shetty
fedcf48ada
fix: Customize form issue where it remains "Not Saved" even after update
fixes: https://github.com/frappe/frappe/issues/16068
3 years ago
Suraj Shetty
adb989fff2
feat: Option to set form dirty even if form save is disabled
3 years ago
Suraj Shetty
c4be72c2d4
fix: Pass skip_dirty_trigger flag to the set_value and model trigger
Also, renamed avoid_dirty to skip_dirty_trigger to be more explicit
3 years ago
Gavin D'souza
4f1d00442c
fix(as_json): Pop None key if exists
JSON doesn't allow null key as per spec, it should be a string only: https://datatracker.ietf.org/doc/html/rfc7159#section-4
ref discussions:
* https://github.com/frappe/frappe/issues/14292
* https://github.com/frappe/frappe/pull/14504/files#r821526085
3 years ago