Ankush Menat
9299df339b
chore: dont rerun patch
Rerunning this isn't required and might cause unexepcted behaviour
[skip ci]
2 年前
mergify[bot]
a67abbe5b2
fix(patch): only run patch if webform has is_multi_step_form field ( #17993 ) ( #17994 )
(cherry picked from commit 6a24748f9a
)
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2 年前
Ankush Menat
40040ebd19
chore: add route history to default log clean up
2 年前
mergify[bot]
b2d145f065
perf: short-circuit guest connection and basic perf tests ( #17988 ) ( #17991 )
* perf: reorder condition to avoid redis call
* test: basic perf tests
(cherry picked from commit f5b8e5f015
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 年前
Ankush Menat
c329e2c2ce
feat: make attachments public on doctypes
When this checkbox is checked, while uploading docs using fileuploader
the default visibility will be set to "public".
At present all uploaded attachments are private, however in following
cases it makes sense to set default as public:
1. Blog post
2. Item catalog
3. Website item
Considering this we decided to add this configurtion so developers can
specify sane default while user still has control over it using
"Customize form"
Enabled this for "blog post" doctype
Unrelatd change: consistent "form settings" section on DocType and customize
form
(cherry picked from commit e8af6b2c16
)
2 年前
Ankush Menat
0202f774d0
fix: don't attempt to delete workspace in prod
(cherry picked from commit bde4e44cf4
)
2 年前
mergify[bot]
e154d77a10
fix: Do not show "Not Saved" on loading System Settings (backport #17967 ) ( #17968 )
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2 年前
Ritwik Puri
1dacb7a622
Merge pull request #17957 from frappe/mergify/bp/version-14-hotfix/pr-17950
chore: update fr translation (backport #17950 )
2 年前
HENRY Florian
47895ffec4
chore: update fr translation ( #17950 )
(cherry picked from commit aac5e3d3c1
)
2 年前
Ankush Menat
ae5cab4ef5
chore: CODEOWNERS
[skip ci]
2 年前
mergify[bot]
cf508f045c
feat(bench): add new bench command for add user (backport #17938 ) ( #17942 )
* feat(bench): add new bench command for add user
(cherry picked from commit 40f54d04b7
)
* test: simplify user addition test
(cherry picked from commit 6ec5c05e4e
)
Co-authored-by: Alaa Alsalehi <alaadiaa@gmail.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 年前
mergify[bot]
84c5cc2242
test: use FrappeTestCase everywhere (backport #17353 ) ( #17952 )
* test: undo custom field creation
(cherry picked from commit 41af9621cd
)
* test: Use FrappeTestCase everywhere
(cherry picked from commit 3e2d2a703a
)
# Conflicts:
# frappe/printing/doctype/print_format/test_print_format.py
# frappe/tests/test_commands.py
# frappe/tests/test_config.py
# frappe/tests/test_oauth20.py
# frappe/tests/test_translate.py
# frappe/tests/test_utils.py
* fix: dont use sendmail with now=True
(cherry picked from commit 1c9ea57279
)
* test: skip badly written test temporarily
(cherry picked from commit 613d8472b4
)
* chore: conflicts
Co-authored-by: Ankush Menat <ankush@frappe.io>
Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
2 年前
mergify[bot]
5f4e0531cd
feat: remove subtree ( #17647 ) ( #17954 )
* feat: remove subtree
* test: remove_subtree
(cherry picked from commit d05ed27a01
)
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2 年前
Suraj Shetty
affcf4940c
Merge pull request #17940 from frappe/mergify/bp/version-14-hotfix/pr-17937
2 年前
Suraj Shetty
a1609abca7
fix: Set last_value for check
- Revert https://github.com/frappe/frappe/pull/17390 since it used to set this.value before triggering change events... due to this this.last_value & this.value was having same value in change events of some control (eg. link field)
- set_input has the responsibility to set this.value and this.last_value properly.
(cherry picked from commit 2e91e92227
)
2 年前
Ankush Menat
9de12a0cee
Merge pull request #17936 from frappe/mergify/bp/version-14-hotfix/pr-17884
fix: permissions dont refresh when switching doc (backport #17884 )
2 年前
Ankush Menat
032dcc4003
refactor: convert control.perm to a property
(cherry picked from commit 722d57637f
)
2 年前
Ankush Menat
2e03bf7749
fix: permissions dont refresh when switching doc
Grid permissions aren't refreshed when switching docs.
Setup permissions like this:
1. Normal perm - read
2. If owner - read + write + others
3. Open a normal doc -> is read only so grid is read only.
4. Now go back and open a created doc -> grid will be read only or empty
(if no rows)
fix: make grid.perm a computed property that refers to form instead of
duplicating this.
ref: ISS-22-23-01733
(cherry picked from commit 80d264a7b4
)
2 年前
mergify[bot]
fb50a90a47
fix: translate import warnings ( #17924 ) ( #17931 )
(cherry picked from commit 63a60c6457
)
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2 年前
mergify[bot]
7af2b19fd1
fix: 'TopBarItem' object does not support item assignment #17926 ( #17927 )
TypeError: 'TopBarItem' object does not support item assignment
(cherry picked from commit 9358655ae2
)
Co-authored-by: Faris Ansari <netchampfaris@users.noreply.github.com>
2 年前
mergify[bot]
7c8a125c74
perf: avoid coalescing wherever possible ( #17920 ) ( #17925 )
(cherry picked from commit cdb0732646
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 年前
Shariq Ansari
7747695485
Merge pull request #17922 from frappe/mergify/bp/version-14-hotfix/pr-17918
2 年前
Shariq Ansari
3a7bacc7be
chore: moved include script from html to web_form.bundle.js
(cherry picked from commit d17fd03958
)
2 年前
Shariq Ansari
db2424bfef
chore: removed unused code
(cherry picked from commit 78ab3d8429
)
2 年前
Shariq Ansari
d555173bc8
revert: use meta fields in standard webforms
(cherry picked from commit 5ca89e0dad
)
2 年前
Ritwik Puri
5e4fd0090f
Merge pull request #17911 from frappe/mergify/bp/version-14-hotfix/pr-17883
fix: fetch email domain values for email account (backport #17883 )
2 年前
phot0n
372b10837d
fix: use debounced frappe.call on domain selection
Also removed tag from domain and service labels in email account doctype
(cherry picked from commit 141693a75b
)
2 年前
phot0n
5dd54073c5
chore: move all email domain attributes to a global variable
(cherry picked from commit c450058a37
)
2 年前
phot0n
5477340e9e
fix: fetch values from email domain for email account
* chore: remove dead code related to fetching the same
(cherry picked from commit a3cd00a3ed
)
2 年前
mergify[bot]
83d6a0b9a3
Merge pull request #17909 from frappe/mergify/bp/version-14-hotfix/pr-17294
chore: remove old code where User Permissions were set in `tabDefaultValue` (backport #17294 )
2 年前
Suraj Shetty
0f44b09bb6
fix: Resolve conflicts
2 年前
Sagar Vora
7dbdfda895
fix: clear `notifications` cache when deleting a Notification
(cherry picked from commit c5face41b3
)
2 年前
Sagar Vora
c4486246da
test: clear `lang_full_dict` from local cache
(cherry picked from commit 2866721a78
)
# Conflicts:
# frappe/tests/test_translate.py
2 年前
Sagar Vora
dc8cd73666
chore: remove old code where User Permissions were set in `tabDefaultValue`
(cherry picked from commit 63e760e3ad
)
3 年前
Suraj Shetty
4c56aaba26
Merge pull request #17908 from frappe/mergify/bp/version-14-hotfix/pr-17863
2 年前
Shariq Ansari
1543bf97a7
feat: added not saved indicator if form is dirty
(cherry picked from commit 2b57e77f29
)
2 年前
Shariq Ansari
6f15acb527
style: rating field style changes in view mode
color field causing error in view mode (fixed)
(cherry picked from commit 7d245268ea
)
2 年前
Shariq Ansari
26089c2b73
fix: include Color field in Web Form fieldtypes
(cherry picked from commit fb8ba3d881
)
2 年前
Shariq Ansari
db30c7f7ba
fix: setup field's change event instead of input change event
(cherry picked from commit 02da933c16
)
2 年前
Shariq Ansari
30ea75af6c
fix: title should never be empty
(cherry picked from commit 4b4d66d2a3
)
2 年前
Shariq Ansari
af05e8868d
fix: show webform name and webform doc name on header
(cherry picked from commit 309b42f1a3
)
2 年前
Shariq Ansari
00af4f8e5c
fix: show introduction in edit mode
(cherry picked from commit 66389932d1
)
2 年前
Shariq Ansari
cab022e4c6
fix: show discard dialog only if form is dirty
(cherry picked from commit b1944916c3
)
2 年前
Shariq Ansari
88186d3243
fix: submit button should always be on extreme right
(cherry picked from commit 364366ae99
)
2 年前
Shariq Ansari
d286ca36c2
fix: text editor overflow issue
(cherry picked from commit c5f64d43bb
)
2 年前
Shariq Ansari
9231bc4e1b
fix: minor success page css changes
(cherry picked from commit 5cdf21d8ee
)
2 年前
Shariq Ansari
69e706f2de
fix: foreach doesnt work for html element looping
(cherry picked from commit fc2defcc3f
)
2 年前
Shariq Ansari
2d7b015d61
fix: remove page breaks without any fields in it
(cherry picked from commit 8bd012da0c
)
2 年前
Shariq Ansari
bacb2cf2e5
fix: replaced clear button with discard button
(cherry picked from commit 9288d0cebf
)
2 年前
Shariq Ansari
57437f957b
test: fixed failing unit test
(cherry picked from commit 6ed42f5213
)
2 年前