Abhirup Pal
8c8249894b
fix: Update label for editing in full page and add custom logic for rendering it. ( #17149 )
3 jaren geleden
Ankush Menat
03f48580ef
test: button with single quote in label
3 jaren geleden
Shariq Ansari
e740ad180d
test: fix for failing Data Control UI test ( #17133 )
3 jaren geleden
gavin
fc9308f8ba
fix: Use same labels for standard fields throughout interfaces ( #17031 )
* fix(model)!: Match labels in meta & model
Labels for fields have been inconsistent. In standard filters, doc.name
would be labelled as "Name" while it's "ID" in the edit filters option.
Similarly for other fields, the same view will address the same fields
differently. This PR aims to get rid of such inconsistencies.
Changes:
* [model] Change label ID for name to 'Name'
* [meta] Match labels of owner, modified, modified_by
* [meta] Add labels for more fields - from model.js
* fix!: get_label to fetch labels as Desk does
* fix!(label): Refer to name field as 'ID' over 'Name'
* test: Use 'ID' label instead of 'Name'
3 jaren geleden
Rushabh Mehta
e66cd830fb
fix(minor): test + tabs
3 jaren geleden
Rushabh Mehta
da9ac52ffb
fix(minor): lint
3 jaren geleden
Rushabh Mehta
e790b5e8b1
fix(minor): added UI test
3 jaren geleden
Rushabh Mehta
378b44a382
fix(minor): fix flaky test
3 jaren geleden
Shariq Ansari
b44235587f
test: fixed failing UI test ( #16958 )
3 jaren geleden
Ankush Menat
fe8520a2bd
fix: duplicate buttons on desk ( #16941 )
3 jaren geleden
Shariq Ansari
3a2cd2650e
test: fixed failing UI test
3 jaren geleden
Shariq Ansari
176518ed2c
fix: Mandatory field bad UX ( #16919 )
Mandatory fields are highlighted red on page load. It should only highlight if we save the document.
**Before:** Form
https://user-images.githubusercontent.com/30859809/168791201-049c1de2-b7f5-4dff-bf40-093ff96d4510.mov
**After:** Form
https://user-images.githubusercontent.com/30859809/168791164-45e2289b-2d2c-4ebb-8b4d-cd2932140572.mov
**Before:** Dialog
https://user-images.githubusercontent.com/30859809/168791207-800ba9e5-b4eb-419f-8a99-f94916c21c79.mov
**After:** Dialog
https://user-images.githubusercontent.com/30859809/168791210-f2761d23-3a60-40c2-8aff-2d2cebbd77fa.mov
Resolves https://github.com/frappe/frappe/issues/16866
3 jaren geleden
Komal-Saraf0609
fea45bf341
test: Added test script for control type "Color" ( #16619 )
3 jaren geleden
Himanshu
70409a3c7b
fix: set translated text to link field ( #15451 )
- Fixes [Issue/15324](https://github.com/frappe/frappe/issues/15324 )
- When selecting a value for Link Field, the English text was set as link field value.
- This PR aims to fix it by setting the translated text as link field value on selection.
Todo:
- [x] Show translated text in the select dropdown
- [x] Set translated value to Link field on select
- [x] Show original value when link field is in focus
- [x] Add option to toggle this behaviour
### Behaviour
- Link field loses focus: show the translated name.
- Link field is focused
- If old value is present
- If options **are** one of [Role, DocType]: show the translated name
- Else: show the name (untranslated) to enable search in untranslated values
- Else: show what the user typed (untranslated) to enable search in untranslated values
- Value is selected: link field loses focus
## Demo
### Link to UOM in a custom Item DocType
The UOM names are in english, so the search needs to happen in english. When possible, the translation is displayed.
#### Before
https://user-images.githubusercontent.com/14891507/156415248-e5e80d05-53dc-4ca8-89c7-998986ff6e99.mov
#### After
https://user-images.githubusercontent.com/14891507/156410386-a874430c-f340-43ed-9c3a-92e8d4d50fc9.mov
### Link to DocType in Customize Form
The DocType names get translated before being searched. This is a preexisting hack in the framework for DocType and Role. In this case, we can search in the translations.
#### Before
https://user-images.githubusercontent.com/14891507/156414648-8e505f8c-9dee-4358-8182-3b358c28bb62.mov
#### After
https://user-images.githubusercontent.com/14891507/156411881-c4ca22e1-1397-4e13-9768-5e16b72f8d6d.mov
https://docs.erpnext.com/docs/v13/user/manual/en/customize-erpnext/customize-form/edit?wiki_page_patch=fdafee2715
3 jaren geleden
Shariq Ansari
78489cd700
feat: Quick List Block for Workspace ( #16887 )
3 jaren geleden
phot0n
edce9a1865
Revert "fix: allow setting autoincrement autoname from customize form"
This reverts commit d43d9594f0
.
3 jaren geleden
phot0n
646d2271b8
fix: allow setting autoincrement autoname from customize form
* chore: updated the warning under autoincrement autoname
3 jaren geleden
Suraj Shetty
aac9378beb
test: Disable flaky test
Unable to find the cause of the flakiness of the test. Disabling it for now.
Also, the form_tour test is full of `wait` which is bad anyway.
3 jaren geleden
Suraj Shetty
bec77dba0d
test: Fix flaky tests
Disable form tour tests
3 jaren geleden
Rushabh Mehta
dfeb16f58d
fix(test): control_dynamic_link.js
3 jaren geleden
Rushabh Mehta
c23cc52948
fix(test): control_dynamic_link.js
3 jaren geleden
Rushabh Mehta
9847019457
fix(test): control_dynamic_link.js
3 jaren geleden
Rushabh Mehta
efd993cdc3
fix(test): control_dynamic_link.js
3 jaren geleden
Rushabh Mehta
ec2c65f0a5
fix(test): control_dynamic_link.js
3 jaren geleden
Komal-Saraf0609
03efa25d03
test: Corrected failed tests
3 jaren geleden
Suraj Shetty
30440026db
fix: Do not allow autoname changes to/from autoincrement in customize form
3 jaren geleden
Suraj Shetty
2f2fc0440d
test: Init UI test for customize form
3 jaren geleden
Shariq Ansari
042f98bcc5
fix: Workspace Miscellaneous fixes ( #16578 )
3 jaren geleden
Shariq Ansari
d558f16e71
test: fixed flaky test for form, timeline_email
3 jaren geleden
Shariq Ansari
09a0077079
style: fixed indentation
3 jaren geleden
Shariq Ansari
8c953b4f74
test: removing drag drop test(flaky)
3 jaren geleden
Shariq Ansari
7f83178556
test: flaky markdown editor fix
3 jaren geleden
Komal-Saraf0609
8592f07363
test: Corrected selector
3 jaren geleden
Komal-Saraf0609
a9de2382a9
test: Fixed sider issues
3 jaren geleden
Komal-Saraf0609
161fa18660
test: Corrected selectors
3 jaren geleden
Faris Ansari
fc4e2780bd
chore: pretty logging for dialog command
3 jaren geleden
Faris Ansari
d1978d8e62
fix: check dates in frappe realm
new Date in Cypress context and new Date in frappe context differs sometimes in CI
3 jaren geleden
Shariq Ansari
ef6bb79f65
test: Typing on focused input issue ( #16669 )
3 jaren geleden
Faris Ansari
9482ac4399
style: semicolons
3 jaren geleden
Faris Ansari
afebaa0a23
test: less flaky date control test
3 jaren geleden
Himanshu
803f1fb061
feat: add/remove fields from kanban board ( #16257 )
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
3 jaren geleden
Suraj Shetty
a0e9b61e04
test: Simplify phone control test
3 jaren geleden
Suraj Shetty
a396afc7d4
fix: Validation error
3 jaren geleden
Komal-Saraf0609
dda56b3759
test: Fixed sider issues
3 jaren geleden
Komal-Saraf0609
651aa36cd2
test: Added script for control type "Data"
3 jaren geleden
Faris Ansari
168bf6d3e4
test: ui test for inserting image in markdown
3 jaren geleden
Noah Jacob
36ca84c9ff
test: suggested changes
3 jaren geleden
lapardnemihk1099
5993a8ba57
chore: sider issues fixed
3 jaren geleden
lapardnemihk1099
27d226f295
test: theme switcher dialog shortcut test
3 jaren geleden
Komal-Saraf0609
02286e4e6f
test: Added test script for control type "Attach" ( #16355 )
Adding automation test script for control/fieldtype "Attach".
The above test script does the following testing:
1. Creating a new doctype with attach fieldtype.
2. Attaching a new image using the "Link" option from the options which the "Attach" button offers.
3. Checking if the URL of the attached image is getting displayed in the field of the newly created doctype.
4. Checking if the clicking on the "Clear" button clears the text in the field and again displays the "Attach" button.
5. Doing all the above testing by using the "Library" option from the options which the "Attach" button offers.
3 jaren geleden