Ankush Menat
de203c3a72
test: upgrade cypress from v6 to v10
chore: run cypress migrator
fix: specPattern should be an array
test: correct intercept URL
This is breaking change in cypress 7.0
test: make list view test rerunnable
test: redo undo tests and add compare doc
test: scroll to action button
chore: drop flaky tests
fix: remove scroll behaviour
fix: clear filters before running count test
test: input delay causes flake
(cherry picked from commit e397b27d29
)
2 年前
mergify[bot]
eaaae9814c
feat: review Custom and Build workspace, move background Job to Build Workspace ( #17981 ) ( #18018 )
* feat: review link for Custom, build and NavBar
* feat: review link for Custom, build and NavBar
* feat: review link for Custom, build and NavBar
* feat: review link for Custom, build and NavBar
* feat: review link for Custom, build and NavBar
* feat: review link for Custom, build and NavBar
* chore: linter json
* fix: replace Block Module By Module Profile
* chore: cypress test
* chore: reset package.json to develop
* refactor: workspace link, system logs section
- removed workspace listview link, visiting list view isn't required for
practically all the tasks
- Frappe Logs -> System Logs
[skip ci]
(cherry picked from commit df9e8c62dd
)
Co-authored-by: HENRY Florian <florian.henry@open-concept.pro>
2 年前
Ankush Menat
c329e2c2ce
feat: make attachments public on doctypes
When this checkbox is checked, while uploading docs using fileuploader
the default visibility will be set to "public".
At present all uploaded attachments are private, however in following
cases it makes sense to set default as public:
1. Blog post
2. Item catalog
3. Website item
Considering this we decided to add this configurtion so developers can
specify sane default while user still has control over it using
"Customize form"
Enabled this for "blog post" doctype
Unrelatd change: consistent "form settings" section on DocType and customize
form
(cherry picked from commit e8af6b2c16
)
2 年前
Shariq Ansari
cb7ef15339
test: fixed failing UI test
(cherry picked from commit 2181233c75
)
2 年前
mergify[bot]
10faee0a04
feat: custom __link_options ( #17699 ) ( #17838 )
* feat: custom __link_optins
* chore: linter fixes
* test: add ui test for custom link option
(cherry picked from commit 1aa3f75d4c
)
Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
2 年前
hrwx
d50db2e0c6
chore: remove untranslated matching
(cherry picked from commit 42a3fe0fa2
)
2 年前
hrwx
a8b2ecb029
chore: set middle name as _Test User for admin
(cherry picked from commit d9c3c03522
)
2 年前
hrwx
1b1886f054
chore: linter fixes
(cherry picked from commit db2e898397
)
2 年前
hrwx
2834ce1b63
refactor: translatable doctypes
(cherry picked from commit b01929405d
)
# Conflicts:
# frappe/contacts/doctype/gender/gender.json
# frappe/contacts/doctype/salutation/salutation.json
2 年前
mergify[bot]
81e23e8862
feat: Webform Success Page and some customization options (backport #17790 ) ( #17809 )
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2 年前
Suraj Shetty
c102124b72
revert: Remove emoji from doctype
Use colored text instead
(cherry picked from commit 6ef41e03e3
)
2 年前
mergify[bot]
86f9fbcc71
fix: Webform Misc Fix (backport #17642 ) ( #17746 )
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2 年前
Ankush Menat
5d6b24f0b1
style: format JS files with prettier
(cherry picked from commit 40f27f908a
)
2 年前
Ankush Menat
5ea96ced3a
test: undo/redo, jump to field UI tests
2 年前
Shariq Ansari
a50e0ffa08
refactor: Webform ( #17232 )
2 年前
Ankush Menat
e762fe9ce1
test: clear filters on ToDo before running test ( #17494 )
2 年前
Ankush Menat
d04df394a5
test: check for uploaded file to be private
2 年前
Shariq Ansari
15018b96fa
test: fixed flaky workspace blocks UI test ( #17436 )
2 年前
Ankush Menat
786d52f6f9
chore: disable recorder UI test
2 年前
Ankush Menat
e63e26890c
fix: show "doc modifed after" load message
3 年前
Ankush Menat
9c5d6feec1
test(cypress): show full response on insert_doc failure ( #17257 )
3 年前
Ankush Menat
6350406305
perf: remove duplicate control assets ( #17237 )
* test: flaky tests due to uncleared filters
* perf: remove duplicate code in assets
Remove controls which are separately bundled too, saves ~1.1MB of
network transfer.
Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
3 年前
Ankush Menat
54824071c2
test: simple test for URL routing with params
3 年前
Shariq Ansari
d9e848ef88
test: added UI test for date range control
3 年前
Abhirup Pal
8c8249894b
fix: Update label for editing in full page and add custom logic for rendering it. ( #17149 )
3 年前
Ankush Menat
03f48580ef
test: button with single quote in label
3 年前
Shariq Ansari
e740ad180d
test: fix for failing Data Control UI test ( #17133 )
3 年前
gavin
fc9308f8ba
fix: Use same labels for standard fields throughout interfaces ( #17031 )
* fix(model)!: Match labels in meta & model
Labels for fields have been inconsistent. In standard filters, doc.name
would be labelled as "Name" while it's "ID" in the edit filters option.
Similarly for other fields, the same view will address the same fields
differently. This PR aims to get rid of such inconsistencies.
Changes:
* [model] Change label ID for name to 'Name'
* [meta] Match labels of owner, modified, modified_by
* [meta] Add labels for more fields - from model.js
* fix!: get_label to fetch labels as Desk does
* fix!(label): Refer to name field as 'ID' over 'Name'
* test: Use 'ID' label instead of 'Name'
3 年前
Rushabh Mehta
e66cd830fb
fix(minor): test + tabs
3 年前
Rushabh Mehta
da9ac52ffb
fix(minor): lint
3 年前
Rushabh Mehta
e790b5e8b1
fix(minor): added UI test
3 年前
Rushabh Mehta
378b44a382
fix(minor): fix flaky test
3 年前
Shariq Ansari
b44235587f
test: fixed failing UI test ( #16958 )
3 年前
Ankush Menat
fe8520a2bd
fix: duplicate buttons on desk ( #16941 )
3 年前
Shariq Ansari
3a2cd2650e
test: fixed failing UI test
3 年前
Shariq Ansari
176518ed2c
fix: Mandatory field bad UX ( #16919 )
Mandatory fields are highlighted red on page load. It should only highlight if we save the document.
**Before:** Form
https://user-images.githubusercontent.com/30859809/168791201-049c1de2-b7f5-4dff-bf40-093ff96d4510.mov
**After:** Form
https://user-images.githubusercontent.com/30859809/168791164-45e2289b-2d2c-4ebb-8b4d-cd2932140572.mov
**Before:** Dialog
https://user-images.githubusercontent.com/30859809/168791207-800ba9e5-b4eb-419f-8a99-f94916c21c79.mov
**After:** Dialog
https://user-images.githubusercontent.com/30859809/168791210-f2761d23-3a60-40c2-8aff-2d2cebbd77fa.mov
Resolves https://github.com/frappe/frappe/issues/16866
3 年前
Komal-Saraf0609
fea45bf341
test: Added test script for control type "Color" ( #16619 )
3 年前
Himanshu
70409a3c7b
fix: set translated text to link field ( #15451 )
- Fixes [Issue/15324](https://github.com/frappe/frappe/issues/15324 )
- When selecting a value for Link Field, the English text was set as link field value.
- This PR aims to fix it by setting the translated text as link field value on selection.
Todo:
- [x] Show translated text in the select dropdown
- [x] Set translated value to Link field on select
- [x] Show original value when link field is in focus
- [x] Add option to toggle this behaviour
### Behaviour
- Link field loses focus: show the translated name.
- Link field is focused
- If old value is present
- If options **are** one of [Role, DocType]: show the translated name
- Else: show the name (untranslated) to enable search in untranslated values
- Else: show what the user typed (untranslated) to enable search in untranslated values
- Value is selected: link field loses focus
## Demo
### Link to UOM in a custom Item DocType
The UOM names are in english, so the search needs to happen in english. When possible, the translation is displayed.
#### Before
https://user-images.githubusercontent.com/14891507/156415248-e5e80d05-53dc-4ca8-89c7-998986ff6e99.mov
#### After
https://user-images.githubusercontent.com/14891507/156410386-a874430c-f340-43ed-9c3a-92e8d4d50fc9.mov
### Link to DocType in Customize Form
The DocType names get translated before being searched. This is a preexisting hack in the framework for DocType and Role. In this case, we can search in the translations.
#### Before
https://user-images.githubusercontent.com/14891507/156414648-8e505f8c-9dee-4358-8182-3b358c28bb62.mov
#### After
https://user-images.githubusercontent.com/14891507/156411881-c4ca22e1-1397-4e13-9768-5e16b72f8d6d.mov
https://docs.erpnext.com/docs/v13/user/manual/en/customize-erpnext/customize-form/edit?wiki_page_patch=fdafee2715
3 年前
Shariq Ansari
78489cd700
feat: Quick List Block for Workspace ( #16887 )
3 年前
phot0n
edce9a1865
Revert "fix: allow setting autoincrement autoname from customize form"
This reverts commit d43d9594f0
.
3 年前
phot0n
646d2271b8
fix: allow setting autoincrement autoname from customize form
* chore: updated the warning under autoincrement autoname
3 年前
Suraj Shetty
aac9378beb
test: Disable flaky test
Unable to find the cause of the flakiness of the test. Disabling it for now.
Also, the form_tour test is full of `wait` which is bad anyway.
3 年前
Suraj Shetty
bec77dba0d
test: Fix flaky tests
Disable form tour tests
3 年前
Rushabh Mehta
dfeb16f58d
fix(test): control_dynamic_link.js
3 年前
Rushabh Mehta
c23cc52948
fix(test): control_dynamic_link.js
3 年前
Rushabh Mehta
9847019457
fix(test): control_dynamic_link.js
3 年前
Rushabh Mehta
efd993cdc3
fix(test): control_dynamic_link.js
3 年前
Rushabh Mehta
ec2c65f0a5
fix(test): control_dynamic_link.js
3 年前
Komal-Saraf0609
03efa25d03
test: Corrected failed tests
3 年前
Suraj Shetty
30440026db
fix: Do not allow autoname changes to/from autoincrement in customize form
3 年前