From 088050b31bcf1a33e090c3f612eabc381eb388f8 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Tue, 28 Jun 2022 18:01:12 +0530 Subject: [PATCH] fix: remove bare exception catching A bare except catches lots of things (like generator iteration end) and should never be used. --- .../razorpay_settings/razorpay_settings.py | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/payments/payment_gateways/doctype/razorpay_settings/razorpay_settings.py b/payments/payment_gateways/doctype/razorpay_settings/razorpay_settings.py index b48d211..b133198 100644 --- a/payments/payment_gateways/doctype/razorpay_settings/razorpay_settings.py +++ b/payments/payment_gateways/doctype/razorpay_settings/razorpay_settings.py @@ -141,8 +141,8 @@ class RazorpaySettings(Document): ) if not resp.get("id"): frappe.log_error(message=str(resp), title="Razorpay Failed while creating subscription") - except: - frappe.log_error(frappe.get_traceback()) + except Exception: + frappe.log_error() # failed pass @@ -181,10 +181,8 @@ class RazorpaySettings(Document): else: frappe.log_error(message=str(resp), title="Razorpay Failed while creating subscription") - except: - frappe.log_error(frappe.get_traceback()) - # failed - pass + except Exception: + frappe.log_error() def prepare_subscription_details(self, settings, **kwargs): if not kwargs.get("subscription_id"): @@ -283,10 +281,8 @@ class RazorpaySettings(Document): else: frappe.log_error(message=str(resp), title="Razorpay Payment not authorized") - except: - frappe.log_error(frappe.get_traceback()) - # failed - pass + except Exception: + frappe.log_error() status = frappe.flags.integration_request.status_code