Ver a proveniência
perf: remove duplicate control assets (#17237)
* test: flaky tests due to uncleared filters
* perf: remove duplicate code in assets
Remove controls which are separately bundled too, saves ~1.1MB of
network transfer.
Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
version-14
Ankush Menat
há 3 anos
committed by
GitHub
ascendente
cometimento
6350406305
Não foi encontrada uma chave conhecida para esta assinatura, na base de dados
ID da chave GPG: 4AEE18F83AFDEB23
3 ficheiros alterados com
5 adições e
1 eliminações
-
cypress/integration/awesome_bar.js
-
cypress/integration/routing.js
-
frappe/public/js/form.bundle.js
|
|
@@ -28,6 +28,7 @@ context('Awesome Bar', () => { |
|
|
|
|
|
|
|
cy.findByPlaceholderText('ID') |
|
|
|
.should('have.value', '%test%'); |
|
|
|
cy.clear_filters(); |
|
|
|
}); |
|
|
|
|
|
|
|
it('navigates to new form', () => { |
|
|
|
|
|
@@ -16,6 +16,10 @@ describe("SPA Routing", { scrollBehavior: false }, () => { |
|
|
|
cy.go_to_list("ToDo"); |
|
|
|
}); |
|
|
|
|
|
|
|
after(() => { |
|
|
|
cy.clear_filters(); // avoid flake in future tests |
|
|
|
}); |
|
|
|
|
|
|
|
it("should apply filter on list view from route", () => { |
|
|
|
test_queries.forEach((query) => { |
|
|
|
const full_url = `${list_view}${query}`; |
|
|
|
|
|
@@ -10,7 +10,6 @@ import "./frappe/form/templates/set_sharing.html"; |
|
|
|
import "./frappe/form/templates/timeline_message_box.html"; |
|
|
|
import "./frappe/form/templates/users_in_sidebar.html"; |
|
|
|
|
|
|
|
import "./frappe/form/controls/control.js"; |
|
|
|
import "./frappe/views/formview.js"; |
|
|
|
import "./frappe/form/form.js"; |
|
|
|
import "./frappe/meta_tag.js"; |
|
|
|