Bläddra i källkod

perf: remove duplicate control assets (#17237)

* test: flaky tests due to uncleared filters

* perf: remove duplicate code in assets

Remove controls which are separately bundled too, saves ~1.1MB of
network transfer.

Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
version-14
Ankush Menat 3 år sedan
committed by GitHub
förälder
incheckning
6350406305
Ingen känd nyckel hittad för denna signaturen i databasen GPG-nyckel ID: 4AEE18F83AFDEB23
3 ändrade filer med 5 tillägg och 1 borttagningar
  1. +1
    -0
      cypress/integration/awesome_bar.js
  2. +4
    -0
      cypress/integration/routing.js
  3. +0
    -1
      frappe/public/js/form.bundle.js

+ 1
- 0
cypress/integration/awesome_bar.js Visa fil

@@ -28,6 +28,7 @@ context('Awesome Bar', () => {

cy.findByPlaceholderText('ID')
.should('have.value', '%test%');
cy.clear_filters();
});

it('navigates to new form', () => {


+ 4
- 0
cypress/integration/routing.js Visa fil

@@ -16,6 +16,10 @@ describe("SPA Routing", { scrollBehavior: false }, () => {
cy.go_to_list("ToDo");
});

after(() => {
cy.clear_filters(); // avoid flake in future tests
});

it("should apply filter on list view from route", () => {
test_queries.forEach((query) => {
const full_url = `${list_view}${query}`;


+ 0
- 1
frappe/public/js/form.bundle.js Visa fil

@@ -10,7 +10,6 @@ import "./frappe/form/templates/set_sharing.html";
import "./frappe/form/templates/timeline_message_box.html";
import "./frappe/form/templates/users_in_sidebar.html";

import "./frappe/form/controls/control.js";
import "./frappe/views/formview.js";
import "./frappe/form/form.js";
import "./frappe/meta_tag.js";


Laddar…
Avbryt
Spara