Bladeren bron

fix: string formatting

version-14
Rushabh Mehta 6 jaren geleden
bovenliggende
commit
bee15006cb
2 gewijzigde bestanden met toevoegingen van 3 en 3 verwijderingen
  1. +2
    -2
      frappe/core/doctype/comment/comment.py
  2. +1
    -1
      frappe/templates/includes/comments/comments.py

+ 2
- 2
frappe/core/doctype/comment/comment.py Bestand weergeven

@@ -149,8 +149,8 @@ def update_comments_in_parent(reference_doctype, reference_name, _comments):


try: try:
# use sql, so that we do not mess with the timestamp # use sql, so that we do not mess with the timestamp
frappe.db.sql("""update `tab%s` set `_comments`=%s where name=%s""" % (reference_doctype,
"%s", "%s"), (json.dumps(_comments), reference_name))
frappe.db.sql("""update `tab{0}` set `_comments`=%s where name=%s""".format(reference_doctype),
(json.dumps(_comments), reference_name))


except Exception as e: except Exception as e:
if frappe.db.is_column_missing(e) and getattr(frappe.local, 'request', None): if frappe.db.is_column_missing(e) and getattr(frappe.local, 'request', None):


+ 1
- 1
frappe/templates/includes/comments/comments.py Bestand weergeven

@@ -30,7 +30,7 @@ def add_comment(comment, comment_email, comment_by, reference_doctype, reference
content = (doc.content content = (doc.content
+ "<p><a href='{0}/desk/#Form/Comment/{1}' style='font-size: 80%'>{2}</a></p>".format(frappe.utils.get_request_site_address(), + "<p><a href='{0}/desk/#Form/Comment/{1}' style='font-size: 80%'>{2}</a></p>".format(frappe.utils.get_request_site_address(),
doc.name, doc.name,
route, _("View Comment")))
_("View Comment")))


# notify creator # notify creator
frappe.sendmail( frappe.sendmail(


Laden…
Annuleren
Opslaan