Browse Source

refactor: remove unused parameter, minor cleanup

version-14
Sagar Vora 4 years ago
parent
commit
c1911a0858
2 changed files with 7 additions and 5 deletions
  1. +3
    -1
      frappe/realtime.py
  2. +4
    -4
      socketio.js

+ 3
- 1
frappe/realtime.py View File

@@ -169,14 +169,16 @@ def get_task_log_file_path(task_id, stream_type):


@frappe.whitelist(allow_guest=True)
def can_subscribe_doc(doctype, docname, sid):
def can_subscribe_doc(doctype, docname):
if os.environ.get('CI'):
return True

from frappe.sessions import Session
from frappe.exceptions import PermissionError
session = Session(None, resume=True).get_session_data()
if not frappe.has_permission(user=session.user, doctype=doctype, doc=docname, ptype='read'):
raise PermissionError()

return True

@frappe.whitelist(allow_guest=True)


+ 4
- 4
socketio.js View File

@@ -142,10 +142,10 @@ io.on('connection', function (socket) {

socket.on('doc_open', function (doctype, docname) {
can_subscribe_doc({
socket: socket,
sid: sid,
doctype: doctype,
docname: docname,
socket,
sid,
doctype,
docname,
callback: () => {
var room = get_open_doc_room(socket, doctype, docname);
socket.join(room);


Loading…
Cancel
Save