Deepesh Garg
182a94e828
Merge pull request #18046 from frappe/version-14-hotfix
chore: weekly version-14 release
2 年之前
Ankush Menat
2db21d5005
fix: show user/pass fields when LDAP is active ( #18043 )
2 年之前
Nikhil Kothari
7249c179ed
feat: option to disable user pass based login ( #18000 )
* Added checkbox to disable pass login in settings
* Added user_pass disable option in Login page context
* Hide user-pass fields when option disabled
* Added check for social login key and LDAP
* feat: Disable API based usr-pwd login
* style: format with black
* refactor: simpify auth validation
No need for else clause
* refactor: fixup sys setting json and move field
* refactor: sys settings validation
* refactor: simpler imports
* chore: undo unintional changes
* test: add test for disabled user pass
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 年之前
Ankush Menat
727adb1054
fix(DX): reduce retry count for esbuild-redis
closes https://github.com/frappe/frappe/issues/17976
2 年之前
Shariq Ansari
b02fe3c59c
Merge pull request #18026 from frappe/mergify/bp/version-14-hotfix/pr-18025
2 年之前
Shariq Ansari
434ed3d153
fix: do not remove workspaces while app is uninstalled
(cherry picked from commit cab95e12f4
)
2 年之前
Shariq Ansari
1285d84aa7
fix: show unique workspaces in sidebar
(cherry picked from commit 7331e3a7be
)
2 年之前
Ankush Menat
de203c3a72
test: upgrade cypress from v6 to v10
chore: run cypress migrator
fix: specPattern should be an array
test: correct intercept URL
This is breaking change in cypress 7.0
test: make list view test rerunnable
test: redo undo tests and add compare doc
test: scroll to action button
chore: drop flaky tests
fix: remove scroll behaviour
fix: clear filters before running count test
test: input delay causes flake
(cherry picked from commit e397b27d29
)
2 年之前
Ankush Menat
1e81a2a2b5
ci: separate cache for UI jobs and selective test
This is reusing normal cache which doesn't contain half the things
(cherry picked from commit 236ab8dbed
)
2 年之前
Ankush Menat
a1191f670e
refactor: dont fetch whole doc for 1 value.
(cherry picked from commit 8541fa4cd3
)
2 年之前
mergify[bot]
eaaae9814c
feat: review Custom and Build workspace, move background Job to Build Workspace ( #17981 ) ( #18018 )
* feat: review link for Custom, build and NavBar
* feat: review link for Custom, build and NavBar
* feat: review link for Custom, build and NavBar
* feat: review link for Custom, build and NavBar
* feat: review link for Custom, build and NavBar
* feat: review link for Custom, build and NavBar
* chore: linter json
* fix: replace Block Module By Module Profile
* chore: cypress test
* chore: reset package.json to develop
* refactor: workspace link, system logs section
- removed workspace listview link, visiting list view isn't required for
practically all the tasks
- Frappe Logs -> System Logs
[skip ci]
(cherry picked from commit df9e8c62dd
)
Co-authored-by: HENRY Florian <florian.henry@open-concept.pro>
2 年之前
mergify[bot]
13015c2dc8
fix: comma looks like a decimal in report summary widget ( #18014 ) ( #18017 )
[skip ci]
(cherry picked from commit 7b646ccec5
)
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2 年之前
Ritwik Puri
79ead89821
Merge pull request #18013 from frappe/mergify/bp/version-14-hotfix/pr-18011
feat: add lang to safe globals (backport #18011 )
2 年之前
barredterra
17cbf4a8b0
refactor: move lang into frappe namespace
(cherry picked from commit d0b753a25d
)
2 年之前
barredterra
0293c113c6
feat: add lang to safe globals
(cherry picked from commit 836fd6ef78
)
2 年之前
Ankush Menat
ac9cfe7f9f
ci: disable parallel tests ( #18008 )
Not required on stable branches.
2 年之前
Ritwik Puri
d182a6c40c
chore: add depreciation warning for event streaming ( #17987 )
inlieu of event_streaming app
2 年之前
mergify[bot]
cfdc57add1
feat: add button to collapse all in tree view ( #17992 ) ( #18003 )
* Added button to collapse tree root node
* Removed unneccessary space
* Collapse all expanded nodes
* style: prettier
* refactor: load first level root nodes by default
Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit e8b0b991ab
)
Co-authored-by: Nikhil Kothari <nik.kothari22@live.com>
2 年之前
Ankush Menat
9299df339b
chore: dont rerun patch
Rerunning this isn't required and might cause unexepcted behaviour
[skip ci]
2 年之前
mergify[bot]
a67abbe5b2
fix(patch): only run patch if webform has is_multi_step_form field ( #17993 ) ( #17994 )
(cherry picked from commit 6a24748f9a
)
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2 年之前
Ankush Menat
40040ebd19
chore: add route history to default log clean up
2 年之前
mergify[bot]
b2d145f065
perf: short-circuit guest connection and basic perf tests ( #17988 ) ( #17991 )
* perf: reorder condition to avoid redis call
* test: basic perf tests
(cherry picked from commit f5b8e5f015
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 年之前
Frappe PR Bot
a3af839770
chore(release): Bumped to Version 14.5.0
# [14.5.0](https://github.com/frappe/frappe/compare/v14.4.3...v14.5.0 ) (2022-08-30)
### Bug Fixes
* 'TopBarItem' object does not support item assignment [#17926 ](https://github.com/frappe/frappe/issues/17926 ) ([#17927 ](https://github.com/frappe/frappe/issues/17927 )) ([7af2b19
](7af2b19fd1
))
* added cancel button in clear form dialog ([95c0868
](95c0868b89
))
* added in_view_mode flag ([b7bd489
](b7bd48938a
))
* clear `notifications` cache when deleting a Notification ([7dbdfda
](7dbdfda895
))
* Do not show "Not Saved" on loading System Settings (backport [#17967 ](https://github.com/frappe/frappe/issues/17967 )) ([#17968 ](https://github.com/frappe/frappe/issues/17968 )) ([e154d77
](e154d77a10
))
* don't attempt to delete workspace in prod ([0202f77
](0202f774d0
))
* fetch values from email domain for email account ([5477340
](5477340e9e
))
* foreach doesnt work for html element looping ([69e706f
](69e706f2de
))
* formatted Section,Column,Page Breaks in webform field table and more ([995ffa3
](995ffa30d9
))
* include Color field in Web Form fieldtypes ([26089c2
](26089c2b73
))
* Keep action button size consistent ([516ee67
](516ee671d8
))
* keep progress dots always in center ([94b5c57
](94b5c572ee
))
* made web form and web list responsive ([2741b91
](2741b91490
))
* made web form skeleton responsive ([f23f909
](f23f909c67
))
* make clear button link which trigger warning dialog ([627a72f
](627a72fa97
))
* minor success page css changes ([9231bc4
](9231bc4e1b
))
* **minor:** success page button css (responsive) ([7746bea
](7746bea3ad
))
* moved banner image in to page header section ([bbba5f1
](bbba5f1a4e
))
* only allow 9 page breaks in web form ([e604b47
](e604b4705a
))
* permissions dont refresh when switching doc ([2e03bf7
](2e03bf7749
))
* remove page breaks without any fields in it ([2d7b015
](2d7b015d61
))
* replaced clear button with discard button ([bacb2cf
](bacb2cf2e5
))
* Resolve conflicts ([0f44b09
](0f44b09bb6
))
* Set last_value for check ([a1609ab
](a1609abca7
))
* setup field's change event instead of input change event ([db30c7f
](db30c7f7ba
))
* show clear button only if form is dirty and ([ba53a2b
](ba53a2b23e
))
* show discard dialog only if form is dirty ([cab022e
](cab022e4c6
))
* show empty fields in web form's view mode ([dda0c89
](dda0c89da2
))
* show introduction in edit mode ([00af4f8
](00af4f8e5c
))
* show Page 1 of 2 only in view mode ([7768b40
](7768b40189
))
* show submit button always if allow_incomplete is enabled ([17472bc
](17472bc8fa
))
* show webform name and webform doc name on header ([af05e88
](af05e8868d
))
* submit button should always be on extreme right ([88186d3
](88186d3243
))
* text editor overflow issue ([d286ca3
](d286ca36c2
))
* title should never be empty ([30ea75a
](30ea75af6c
))
* translate import warnings ([#17924 ](https://github.com/frappe/frappe/issues/17924 )) ([#17931 ](https://github.com/frappe/frappe/issues/17931 )) ([fb50a90
](fb50a90a47
))
* use debounced frappe.call on domain selection ([372b108
](372b10837d
))
### Features
* added not saved indicator if form is dirty ([1543bf9
](1543bf97a7
))
* **bench:** add new bench command for add user (backport [#17938 ](https://github.com/frappe/frappe/issues/17938 )) ([#17942 ](https://github.com/frappe/frappe/issues/17942 )) ([cf508f0
](cf508f045c
))
* make attachments public on doctypes ([c329e2c
](c329e2c2ce
))
* remove subtree ([#17647 ](https://github.com/frappe/frappe/issues/17647 )) ([#17954 ](https://github.com/frappe/frappe/issues/17954 )) ([5f4e053
](5f4e0531cd
))
### Performance Improvements
* avoid coalescing wherever possible ([#17920 ](https://github.com/frappe/frappe/issues/17920 )) ([#17925 ](https://github.com/frappe/frappe/issues/17925 )) ([7c8a125
](7c8a125c74
))
### Reverts
* use meta fields in standard webforms ([d555173
](d555173bc8
))
2 年之前
Ankush Menat
5c26924ce6
Merge pull request #17986 from frappe/version-14-hotfix
chore: weekly version 14 release
2 年之前
Frappe PR Bot
a5df188ada
chore(release): Bumped to Version 14.4.3
## [14.4.3](https://github.com/frappe/frappe/compare/v14.4.2...v14.4.3 ) (2022-08-26)
### Bug Fixes
* don't attempt to delete workspace in prod ([#17975 ](https://github.com/frappe/frappe/issues/17975 )) ([8f4e51c
](8f4e51ceeb
))
2 年之前
mergify[bot]
8f4e51ceeb
fix: don't attempt to delete workspace in prod ( #17975 )
(cherry picked from commit bde4e44cf4
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 年之前
Ankush Menat
c329e2c2ce
feat: make attachments public on doctypes
When this checkbox is checked, while uploading docs using fileuploader
the default visibility will be set to "public".
At present all uploaded attachments are private, however in following
cases it makes sense to set default as public:
1. Blog post
2. Item catalog
3. Website item
Considering this we decided to add this configurtion so developers can
specify sane default while user still has control over it using
"Customize form"
Enabled this for "blog post" doctype
Unrelatd change: consistent "form settings" section on DocType and customize
form
(cherry picked from commit e8af6b2c16
)
2 年之前
Ankush Menat
0202f774d0
fix: don't attempt to delete workspace in prod
(cherry picked from commit bde4e44cf4
)
2 年之前
mergify[bot]
e154d77a10
fix: Do not show "Not Saved" on loading System Settings (backport #17967 ) ( #17968 )
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2 年之前
Ritwik Puri
1dacb7a622
Merge pull request #17957 from frappe/mergify/bp/version-14-hotfix/pr-17950
chore: update fr translation (backport #17950 )
2 年之前
HENRY Florian
47895ffec4
chore: update fr translation ( #17950 )
(cherry picked from commit aac5e3d3c1
)
2 年之前
Ankush Menat
ae5cab4ef5
chore: CODEOWNERS
[skip ci]
2 年之前
mergify[bot]
cf508f045c
feat(bench): add new bench command for add user (backport #17938 ) ( #17942 )
* feat(bench): add new bench command for add user
(cherry picked from commit 40f54d04b7
)
* test: simplify user addition test
(cherry picked from commit 6ec5c05e4e
)
Co-authored-by: Alaa Alsalehi <alaadiaa@gmail.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 年之前
mergify[bot]
84c5cc2242
test: use FrappeTestCase everywhere (backport #17353 ) ( #17952 )
* test: undo custom field creation
(cherry picked from commit 41af9621cd
)
* test: Use FrappeTestCase everywhere
(cherry picked from commit 3e2d2a703a
)
# Conflicts:
# frappe/printing/doctype/print_format/test_print_format.py
# frappe/tests/test_commands.py
# frappe/tests/test_config.py
# frappe/tests/test_oauth20.py
# frappe/tests/test_translate.py
# frappe/tests/test_utils.py
* fix: dont use sendmail with now=True
(cherry picked from commit 1c9ea57279
)
* test: skip badly written test temporarily
(cherry picked from commit 613d8472b4
)
* chore: conflicts
Co-authored-by: Ankush Menat <ankush@frappe.io>
Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
2 年之前
mergify[bot]
5f4e0531cd
feat: remove subtree ( #17647 ) ( #17954 )
* feat: remove subtree
* test: remove_subtree
(cherry picked from commit d05ed27a01
)
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2 年之前
Suraj Shetty
affcf4940c
Merge pull request #17940 from frappe/mergify/bp/version-14-hotfix/pr-17937
2 年之前
Suraj Shetty
a1609abca7
fix: Set last_value for check
- Revert https://github.com/frappe/frappe/pull/17390 since it used to set this.value before triggering change events... due to this this.last_value & this.value was having same value in change events of some control (eg. link field)
- set_input has the responsibility to set this.value and this.last_value properly.
(cherry picked from commit 2e91e92227
)
2 年之前
Ankush Menat
9de12a0cee
Merge pull request #17936 from frappe/mergify/bp/version-14-hotfix/pr-17884
fix: permissions dont refresh when switching doc (backport #17884 )
2 年之前
Ankush Menat
032dcc4003
refactor: convert control.perm to a property
(cherry picked from commit 722d57637f
)
2 年之前
Ankush Menat
2e03bf7749
fix: permissions dont refresh when switching doc
Grid permissions aren't refreshed when switching docs.
Setup permissions like this:
1. Normal perm - read
2. If owner - read + write + others
3. Open a normal doc -> is read only so grid is read only.
4. Now go back and open a created doc -> grid will be read only or empty
(if no rows)
fix: make grid.perm a computed property that refers to form instead of
duplicating this.
ref: ISS-22-23-01733
(cherry picked from commit 80d264a7b4
)
2 年之前
Frappe PR Bot
4e2c226f64
chore(release): Bumped to Version 14.4.2
## [14.4.2](https://github.com/frappe/frappe/compare/v14.4.1...v14.4.2 ) (2022-08-24)
### Bug Fixes
* 'TopBarItem' object does not support item assignment [#17926 ](https://github.com/frappe/frappe/issues/17926 ) ([42a8203
](42a8203d54
))
2 年之前
mergify[bot]
42a8203d54
fix: 'TopBarItem' object does not support item assignment #17926
TypeError: 'TopBarItem' object does not support item assignment
(cherry picked from commit 9358655ae2
)
Co-authored-by: Faris Ansari <netchampfaris@users.noreply.github.com>
(cherry picked from commit 7af2b19fd1
)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 年之前
mergify[bot]
fb50a90a47
fix: translate import warnings ( #17924 ) ( #17931 )
(cherry picked from commit 63a60c6457
)
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2 年之前
mergify[bot]
7af2b19fd1
fix: 'TopBarItem' object does not support item assignment #17926 ( #17927 )
TypeError: 'TopBarItem' object does not support item assignment
(cherry picked from commit 9358655ae2
)
Co-authored-by: Faris Ansari <netchampfaris@users.noreply.github.com>
2 年之前
mergify[bot]
7c8a125c74
perf: avoid coalescing wherever possible ( #17920 ) ( #17925 )
(cherry picked from commit cdb0732646
)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2 年之前
Shariq Ansari
7747695485
Merge pull request #17922 from frappe/mergify/bp/version-14-hotfix/pr-17918
2 年之前
Shariq Ansari
3a7bacc7be
chore: moved include script from html to web_form.bundle.js
(cherry picked from commit d17fd03958
)
2 年之前
Shariq Ansari
db2424bfef
chore: removed unused code
(cherry picked from commit 78ab3d8429
)
2 年之前
Shariq Ansari
d555173bc8
revert: use meta fields in standard webforms
(cherry picked from commit 5ca89e0dad
)
2 年之前
Ritwik Puri
5e4fd0090f
Merge pull request #17911 from frappe/mergify/bp/version-14-hotfix/pr-17883
fix: fetch email domain values for email account (backport #17883 )
2 年之前