in https://github.com/frappe/frappe/pull/9382 snyk was added in
package.json yet yarn.lock wasnt updated. this makes changes in
yarn.lock file after a run of `bench setup requirements` which would
possibly cause `bench update` to break on the next run too.
* fix(base_list): Verify that filters are not undefined/empty. #9468
Fixes an issue with empty filters in certain list views as referenced in #9467
* style: Fix formatting issue
Co-Authored-By: Himanshu <himanshuwarekar@yahoo.com>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
* fix: Resend Welcome Email
* fix: Removed Space in Resend Welcome Email
* fix: Removed Space in Resend Welcome Email
* Send welcome mail called from frm
* Passing Parameter to msgprint
* Passing Parameter to msgprint
* Removed Unused Function
* Removed Unused Space
Co-authored-by: pinka0925 <44537026+pinka0925@users.noreply.github.com>
* fix: better logging for slack
* chore: cleanup code and get from dict
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
Co-authored-by: Chinmay Pai <chinmaydpai@gmail.com>
Old:
skip_total_row = result['skip_total_row'] if 'skip_total_row' in result else ''
result["add_total_row"] = report.add_total_row and not skip_total_row
New:
result["add_total_row"] = report.add_total_row and not result.get('skip_total_row')
* fix: sender is not set to current user
I am not sure if I did it right:
1. import frappe
2. check if the sender is None: using frappe.session.user to fetch email address for current user
* fix: update the correct field name for S3-backup-setting
The field variable name should be updated to 'notify_email' instead of 'notification_email'.
* style: remove a trailing whitespace
* fix: Assign notify_email instead of calling frappe.db.get_value twice
* chore: remove default sender and notify_email check
* default sender already gets set in queue.py, so there's no need for a
check inside __init__.py
* notify_email seems to be a mandatory field, so there's no need to
check if the field has a value (assuming that it always will).
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
Co-authored-by: Chinmay Pai <chinmaydpai@gmail.com>