This only affects OAuth clients that use `id_token` obtained from `frappe.integrations.oauth2.get_token`.
Doesn't affect OAuth clients that ignore id_token and explicitly use `frappe.integrations.oauth2.openid_profile` endpoint for getting user details. e.g. Frappe OAuth client.
A simple way to replicate this is to setup Frappe-Frappe OAuth client-server pair and use `login_via_oauth2_id_token` instead of `login_via_oauth2` in `login_via_frappe`.
This only affects OAuth clients that use `id_token` obtained from `frappe.integrations.oauth2.get_token`.
Doesn't affect OAuth clients that ignore id_token and explicitly use `frappe.integrations.oauth2.openid_profile` endpoint for getting user details. e.g. Frappe OAuth client.
A simple way to replicate this is to setup Frappe-Frappe OAuth client-server pair and use `login_via_oauth2_id_token` instead of `login_via_oauth2` in `login_via_frappe`.
Previous changes only made it refresh on change of filters, this change
now updates URL ALWAYS.
Co-Auhtored-By: Suraj Shetty <surajshetty3416@gmail.com>
* feat: set image as footer in letter head
* fix: do not hide footer section
* fix: hide footer source
* style: black
* fix: reduce code for setting image as html
* fix: Force system admin role only if active
* fix(ui): tab refresh was not implemented
* fix(minor): Onboarding: add option to view list view in create action
* fix(minor): js lint
* fix: allow All to select a User
* test: user permissions affecting User
* refactor: filter_dynamic_link_doctypes API
* Added typing, better variable naming
* Remove unnecessary re-iterations
* Optimize queries and membership processing
* perf: Check query type via is_query_type
* chore: Drop duplicate get_frontmatter definition
* perf: Login Page
Improves performance 3x - from 0.047s to 0.017s
* Use frappe.get_*_settings to query table once
* Use cached LDAP Settings' document via get_ldap_client_settings
* Use single get_all to query all Social Login providers and related
data
* Skip provider if client_secret doesn't exist
* perf: About Us Settings
Use cached document for building /about page
* perf: App Page
Reduced time taken for get_context to execute from 0.035s to 0.02s (75%
reduction)
* perf: Patch qb only once - not on every init
* perf: Fetch and cache entire settings' dicts
* refactor!: frappe.db.get_singles_dict
* Cast single's values as their fieldtypes before returning
* Support previously dead debug parameter
* Consider single with no meta as non-existent; skip query
Decided to go ahead with the breaking change given the nature of the
existing usages of get_singles_dict :crie:
* ci: Run tests bypassing roulette with labels "Run UI Tests", "Run Server Tests"
* test: Scheduler tests cleanup
* chore: linter changes
* chore: linter changes
* chore: linter changes
* fix: set HTML as default
to keep existing formats working
* refactor: no **kwargs
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Rushabh Mehta <rmehta@gmail.com>
Co-authored-by: Gavin D'souza <gavin18d@gmail.com>