瀏覽代碼

fix: remove bare exception catching

A bare except catches lots of things (like generator iteration end) and should never be used.
pull/2/head
Ankush Menat 2 年之前
父節點
當前提交
088050b31b
共有 1 個檔案被更改,包括 6 行新增10 行删除
  1. +6
    -10
      payments/payment_gateways/doctype/razorpay_settings/razorpay_settings.py

+ 6
- 10
payments/payment_gateways/doctype/razorpay_settings/razorpay_settings.py 查看文件

@@ -141,8 +141,8 @@ class RazorpaySettings(Document):
) )
if not resp.get("id"): if not resp.get("id"):
frappe.log_error(message=str(resp), title="Razorpay Failed while creating subscription") frappe.log_error(message=str(resp), title="Razorpay Failed while creating subscription")
except:
frappe.log_error(frappe.get_traceback())
except Exception:
frappe.log_error()
# failed # failed
pass pass


@@ -181,10 +181,8 @@ class RazorpaySettings(Document):
else: else:
frappe.log_error(message=str(resp), title="Razorpay Failed while creating subscription") frappe.log_error(message=str(resp), title="Razorpay Failed while creating subscription")


except:
frappe.log_error(frappe.get_traceback())
# failed
pass
except Exception:
frappe.log_error()


def prepare_subscription_details(self, settings, **kwargs): def prepare_subscription_details(self, settings, **kwargs):
if not kwargs.get("subscription_id"): if not kwargs.get("subscription_id"):
@@ -283,10 +281,8 @@ class RazorpaySettings(Document):
else: else:
frappe.log_error(message=str(resp), title="Razorpay Payment not authorized") frappe.log_error(message=str(resp), title="Razorpay Payment not authorized")


except:
frappe.log_error(frappe.get_traceback())
# failed
pass
except Exception:
frappe.log_error()


status = frappe.flags.integration_request.status_code status = frappe.flags.integration_request.status_code




Loading…
取消
儲存