Przeglądaj źródła

fix: remove bare exception catching

A bare except catches lots of things (like generator iteration end) and should never be used.
pull/2/head
Ankush Menat 2 lat temu
rodzic
commit
088050b31b
1 zmienionych plików z 6 dodań i 10 usunięć
  1. +6
    -10
      payments/payment_gateways/doctype/razorpay_settings/razorpay_settings.py

+ 6
- 10
payments/payment_gateways/doctype/razorpay_settings/razorpay_settings.py Wyświetl plik

@@ -141,8 +141,8 @@ class RazorpaySettings(Document):
)
if not resp.get("id"):
frappe.log_error(message=str(resp), title="Razorpay Failed while creating subscription")
except:
frappe.log_error(frappe.get_traceback())
except Exception:
frappe.log_error()
# failed
pass

@@ -181,10 +181,8 @@ class RazorpaySettings(Document):
else:
frappe.log_error(message=str(resp), title="Razorpay Failed while creating subscription")

except:
frappe.log_error(frappe.get_traceback())
# failed
pass
except Exception:
frappe.log_error()

def prepare_subscription_details(self, settings, **kwargs):
if not kwargs.get("subscription_id"):
@@ -283,10 +281,8 @@ class RazorpaySettings(Document):
else:
frappe.log_error(message=str(resp), title="Razorpay Payment not authorized")

except:
frappe.log_error(frappe.get_traceback())
# failed
pass
except Exception:
frappe.log_error()

status = frappe.flags.integration_request.status_code



Ładowanie…
Anuluj
Zapisz